Issue 8854004: Remove the check of the whitelist entries in ClientPhishingResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8854004: Remove the check of the whitelist entries in ClientPhishingResponse. (Closed)

Created:
9 years ago by Brian Ryner

Modified:
9 years ago

Reviewers:
noelutz, mattm

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the check of the whitelist entries in ClientPhishingResponse. The URL is always included in the pingback now, so this whitelist checking can happen on the server. Also, mark this and the ClientPhishingRequest.hash_prefix field as OBSOLETE in the protocol buffer file. BUG=none TEST=updated ClientSideDetectionServiceTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113561

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -103 lines)			Patch
M	chrome/browser/safe_browsing/client_side_detection_service.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_service.cc	View	3 chunks	+1 line, -49 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_service_unittest.cc	View	2 chunks	+2 lines, -43 lines	0 comments	Download
M	chrome/common/safe_browsing/csd.proto	View	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

noelutz

lgtm I think you can safely remove the histogram as well. thanks, noé.

9 years ago (2011-12-08 03:16:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/8854004/1

9 years ago (2011-12-08 03:21:57 UTC) #4

Change committed as 113561

Expand Messages | Collapse Messages