Honor profile directory when creating new window in existing browser

Honor profile directory when creating new window in existing browser

Using the "-profile-directory" switch didn't work if the browser was already running.

The problem was that we were ignoring the switch and just using the last used profile.

BUG=100461
TEST=Ran Chrome with the first profile open. Launched a 2nd instance with "-profile-directory" and verified that the correct profile window opened.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113534

[Robert Sesek, 2011-12-07 18:14:53]

I'm not familiar enough with this code to do an adequate review.

[sky, 2011-12-07 18:28:54]

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:1525: ProcessCmdLineImpl(cmd_line, cur_dir,
false, profile, NULL, NULL);
Seems like you need a if (!profile) NOTREACHED();return; here to balance code on
linux side.

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init.h
File chrome/browser/ui/browser_init.h (right):

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.h:54: static void
ProcessCommandLinePostStartup(const CommandLine& cmd_line,
Maybe this should be named ProcessCommandLineAlreadyRunning.

[sail, 2011-12-07 18:34:59]

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:1525: ProcessCmdLineImpl(cmd_line, cur_dir,
false, profile, NULL, NULL);
On 2011/12/07 18:28:55, sky wrote:
> Seems like you need a if (!profile) NOTREACHED();return; here to balance code
on
> linux side.

Done.

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init.h
File chrome/browser/ui/browser_init.h (right):

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.h:54: static void
ProcessCommandLinePostStartup(const CommandLine& cmd_line,
On 2011/12/07 18:28:55, sky wrote:
> Maybe this should be named ProcessCommandLineAlreadyRunning.

Done.

http://codereview.chromium.org/8854001/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.h:54: static void
ProcessCommandLinePostStartup(const CommandLine& cmd_line,
On 2011/12/07 18:28:55, sky wrote:
> Maybe this should be named ProcessCommandLineAlreadyRunning.

Done.

[sky, 2011-12-07 21:55:52]

LGTM

[commit-bot: I haz the power, 2011-12-07 22:27:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8854001/5001

[commit-bot: I haz the power, 2011-12-08 02:21:22]

Change committed as 113534