Issue 8851010: OS X: Remove "Language Settings" menu item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8851010: OS X: Remove "Language Settings" menu item (Closed)

Created:
9 years ago by jeremy

Modified:
9 years ago

Reviewers:
Avi (use Gerrit), Nico

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

OS X: Remove "Language Settings" menu item Since we're using the native spellchecker, this menu item is no longer needed. BUG=None TEST=Right click on a text field in web content, go to the "Spelling and Grammar" context menu. "Languages and Settings" should no longer appear as an option. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113500

Patch Set 1 #

Patch Set 2 : a #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/8851010/1001

9 years ago (2011-12-07 21:46:58 UTC) #3

Nico

Isn't this also used to set the accept-languages header, and for IDN decisions?

9 years ago (2011-12-08 21:14:30 UTC) #5

jeremy

9 years ago (2011-12-11 12:40:14 UTC) #6

This CL did not remove the pref pane from WebUI, just the menu item used to
open that page directly from the contextual spelling menu on Mac.

This menu item was *always disabled on OS X* anyway, but now that we're
removing Hunspell we don't need it since we use the system spelling engine
and the language pane is only used for the purposes you noted (not for
spelling).

On Thu, Dec 8, 2011 at 11:14 PM, <thakis@chromium.org> wrote:

> Isn't this also used to set the accept-languages header, and for IDN
> decisions?
>
>
http://codereview.chromium.**org/8851010/<http://codereview.chromium.org/8851...
>

Expand Messages | Collapse Messages