src/data-flow.cc - Issue 885004: Only invoke reaching definitions if there are >0 variables and >0 definitions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/data-flow.cc

Issue 885004: Only invoke reaching definitions if there are >0 variables and >0 definitions... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/data-flow.cc

===================================================================

--- src/data-flow.cc (revision 4119)

+++ src/data-flow.cc (working copy)

@@ -2061,7 +2061,7 @@

void ReachingDefinitions::Compute() {

- if (definitions_->is_empty()) return;

+ ASSERT(!definitions_->is_empty());

Kevin Millikin (Chromium) 2010/03/12 14:58:16 I'd leave this check here.

int variable_count = variables_.length();

int definition_count = definitions_->length();

« src/compiler.cc ('K') | « src/compiler.cc ('k') | no next file » | no next file with comments »