Issue 885004: Only invoke reaching definitions if there are >0 variables and >0 definitions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885004: Only invoke reaching definitions if there are >0 variables and >0 definitions... (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Only invoke reaching definitions if there are >0 variables and >0 definitions. Committed: http://code.google.com/p/v8/source/detail?r=4120

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	src/compiler.cc	View		2 chunks	+12 lines, -8 lines	1 comment	Download
	M	src/data-flow.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

10 years, 9 months ago (2010-03-12 14:58:15 UTC) #2

LGTM, with a suggestion.

http://codereview.chromium.org/885004/diff/1/3
File src/compiler.cc (right):

http://codereview.chromium.org/885004/diff/1/3#newcode98
src/compiler.cc:98: if (variable_count > 0 && builder.definitions()->length() >
0) {
Hmm.  I'd let the ReachingDefinitions class check the definitions() length
itself.

http://codereview.chromium.org/885004/diff/1/2
File src/data-flow.cc (right):

http://codereview.chromium.org/885004/diff/1/2#newcode2064
src/data-flow.cc:2064: ASSERT(!definitions_->is_empty());
I'd leave this check here.

Expand Messages | Collapse Messages