Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 8850006: Remove temp. code to disable "Languages and Settings" on OS X. (Closed)

Created:
9 years ago by jeremy
Modified:
9 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove temp. code to disable "Languages and Settings" on OS X. The "Languages and Settings" menu item should not be present in the first place in the spellcheck context menu on OS X. I'll remove the menu item in a followup CL but in the meantime we can remove the code that specifically disables the command on Mac. In the interim having it enabled doesn't do any harm. BUG=69944 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jeremy
9 years ago (2011-12-07 19:27:44 UTC) #1
Avi (use Gerrit)
lgtm
9 years ago (2011-12-07 19:30:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/8850006/1
9 years ago (2011-12-07 21:48:38 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-07 23:03:39 UTC) #4
Change committed as 113495

Powered by Google App Engine
This is Rietveld 408576698