chrome/renderer/extensions/extension_resource_request_policy.cc - Issue 8849010: Add 'web_accessible_resource" keyword for version 2 extension manifests. This makes extension res...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_resource_request_policy.cc

Issue 8849010: Add 'web_accessible_resource" keyword for version 2 extension manifests. This makes extension res... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_unittest.cc ('k') | chrome/test/data/extensions/api_test/extension_resource_request_policy/web_accessible/accessible_resource.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/extension_resource_request_policy.cc

===================================================================

--- chrome/renderer/extensions/extension_resource_request_policy.cc (revision 113054)

+++ chrome/renderer/extensions/extension_resource_request_policy.cc (working copy)

@@ -38,6 +38,15 @@

return false;

}

+ // Disallow loading of extension resources which are not explicitely listed

+ // as web accessible if the manifest version is 2 or greater.

+ if (extension->manifest_version() < 2 &&

abarth-chromium 2011/12/07 22:55:34 Do you mean >= 2?

Cris Neckar 2011/12/09 00:13:06 Done.

+ !extension->CanWebAccessResource(resource_url.path())) {

+ LOG(ERROR) << "Denying load of " << resource_url.spec() << " which "

+ << "is not a web accessible resource.";

+ return false;

+ }

return true;

}