Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 8849007: Add a mechanism to launch the utility process from the zygote on Linux. (Closed)

Created:
9 years ago by Jorge Lucangeli Obes
Modified:
9 years ago
Reviewers:
Aaron Boodman, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add a mechanism to launch the utility process from the zygote on Linux. Allow the users of the utility process to specify whether the zygote should be used on Linux. This will allow sandboxing the uses of the utility process that don't do FS access. This is the first step to get the utility process sandboxed on Linux. Since most of the uses of the utility process don't do file access, launching all of those from the zygote will simplify sandboxing the one that does: extension unpacking. Subsequent CLs will port the uses of the utility process that don't do file access to launch from the zygote. BUG=93109 TEST=No functional changes yet, but test that nothing broke by running browser_tests::ExtensionWebstorePrivateApiTest.* and also logging into Chromium and installing an extension from the Web Store. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113914

Patch Set 1 #

Patch Set 2 : Rebased to ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/app/content_main.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/utility_process_host.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/utility_process_host.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Jorge Lucangeli Obes
Tread more carefully this time. First get the API in, and then port uses of ...
9 years ago (2011-12-07 20:17:47 UTC) #1
jam
lgtm
9 years ago (2011-12-07 21:52:55 UTC) #2
Jorge Lucangeli Obes
On 2011/12/07 21:52:55, John Abd-El-Malek wrote: > lgtm aa@: just checking whether this fell through ...
9 years ago (2011-12-08 23:43:16 UTC) #3
Aaron Boodman
lgtm
9 years ago (2011-12-09 01:44:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/8849007/8001
9 years ago (2011-12-09 19:04:10 UTC) #5
commit-bot: I haz the power
Try job failure for 8849007-8001 (retry) on win_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-09 21:46:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/8849007/8001
9 years ago (2011-12-10 00:06:52 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-10 01:30:57 UTC) #8
Change committed as 113914

Powered by Google App Engine
This is Rietveld 408576698