Issue 8849005: Don't initialize NSS before calling SSL_ClearSessionCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8849005: Don't initialize NSS before calling SSL_ClearSessionCache. (Closed)

Created:
9 years ago by wtc

Modified:
9 years ago

Reviewers:
cbentzel, mattm

CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Don't initialize NSS before calling SSL_ClearSessionCache. If NSS is not initialized, conceptually the SSL session cache is empty. So it doesn't make sense to initialize NSS just to clear an empty SSL session cache. Remove the suppression for the leak this CL fixes from suppressions_mac.txt. Widen a related suppression in suppressions.txt to cover this leak. R=mattm@chromium.org,cbentzel@chromium.org BUG=105431, 95718 TEST=valgrind bots should not report a leak in SSL_ClearSessionCache. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113715

Patch Set 1 #

Patch Set 2 : Sync with tip of tree #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -22 lines)			Patch
M	net/socket/ssl_client_socket_nss.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

wtc

mattm: please review the entire CL. cbentzel: please review the changes to the two suppressions ...

9 years ago (2011-12-07 19:14:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/8849005/5001

9 years ago (2011-12-08 22:45:12 UTC) #3

LGTM on the suppressions.

Sorry for being so slow on the review.

Expand Messages | Collapse Messages