Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 8848001: Make sure PluginDataRemoverImpl::Init is executed after the constructor has finished. (Closed)

Created:
9 years ago by Bernhard Bauer
Modified:
9 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Mattias Nissler (ping if slow)
Visibility:
Public.

Description

Make sure PluginDataRemoverImpl::Init is executed after the constructor has finished. BUG=106709 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113593

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -34 lines) Patch
M content/browser/plugin_data_remover_impl.cc View 1 7 chunks +33 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bernhard Bauer
Please review.
9 years ago (2011-12-07 18:14:22 UTC) #1
jam
lgtm http://codereview.chromium.org/8848001/diff/1/content/browser/plugin_data_remover_impl.cc File content/browser/plugin_data_remover_impl.cc (right): http://codereview.chromium.org/8848001/diff/1/content/browser/plugin_data_remover_impl.cc#newcode226 content/browser/plugin_data_remover_impl.cc:226: BrowserThread::PostTask( nit: usually this is solved by having ...
9 years ago (2011-12-07 21:57:12 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/8848001/diff/1/content/browser/plugin_data_remover_impl.cc File content/browser/plugin_data_remover_impl.cc (right): http://codereview.chromium.org/8848001/diff/1/content/browser/plugin_data_remover_impl.cc#newcode226 content/browser/plugin_data_remover_impl.cc:226: BrowserThread::PostTask( On 2011/12/07 21:57:12, John Abd-El-Malek wrote: > nit: ...
9 years ago (2011-12-08 09:43:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/8848001/5001
9 years ago (2011-12-08 09:43:27 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-08 11:14:35 UTC) #5
Change committed as 113593

Powered by Google App Engine
This is Rietveld 408576698