Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: scripts/master/try_job_base_bb8.py

Issue 8847005: Add decorations to bot names for modifying parts of try sets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/try_job_base_bb8.py
===================================================================
--- scripts/master/try_job_base_bb8.py (revision 113400)
+++ scripts/master/try_job_base_bb8.py (working copy)
@@ -8,6 +8,7 @@
from buildbot.schedulers.trysched import BadJobfile
from twisted.internet import defer
+import master.try_job_decoration as decor
class TryJobBaseMixIn:
def __init__(self):
@@ -42,6 +43,8 @@
reason=parsed_job['name'],
external_idstring=parsed_job['name'],
builderNames=parsed_job['bot'],
Peter Mayo 2011/12/07 16:38:00 We may need to break this down to do separately pe
Peter Mayo 2011/12/09 21:29:08 Done.
- properties=self.get_props(parsed_job))
+ properties=decor.parse_decoration(
+ self.get_props(parsed_job),
+ ':'.join(parsed_job['build_name'].split(':')[1:])))
d.addCallback(create_buildset)
d.addErrback(log.err, "Failed to queue a try job!")

Powered by Google App Engine
This is Rietveld 408576698