Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: scripts/master/try_job_base.py

Issue 8847005: Add decorations to bot names for modifying parts of try sets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/try_job_base.py
===================================================================
--- scripts/master/try_job_base.py (revision 113400)
+++ scripts/master/try_job_base.py (working copy)
@@ -72,19 +72,20 @@
try_int('patchset')
try_int('issue')
- builder_names = []
+ build_names = []
if 'bot' in options:
- builder_names = options.get('bot', '').split(',')
- options['bot'] = self.pools.Select(builder_names, options['project'])
+ build_names = options.get('bot', '').split(',')
+ options['bot'] = self.pools.Select(build_names, options['project'])
+ bot_names = [b.split(':')[0] for b in options['bot']]
log.msg(
- 'Choose %s for job %s' % (','.join(options['bot']), options['reason']))
+ 'Chose %s for job %s' % (','.join(bot_names), options['reason']))
Peter Mayo 2011/12/07 16:38:00 Only the tense change is necessary.
Peter Mayo 2011/12/09 21:29:08 Done.
return options
def get_props(self, options):
"""Current job extra properties that are not related to the source stamp.
Initialize with the Scheduler's base properties.
"""
- keys = ('clobber', 'issue', 'patchset', 'rietveld', 'testfilter')
+ keys = ('clobber', 'issue', 'patchset', 'rietveld', 'testfilter', 'builds')
Peter Mayo 2011/12/07 16:38:00 This can go away now.
Peter Mayo 2011/12/09 21:29:08 Done.
# All these settings have no meaning when False or not set, so don't set
# them in that case.
properties = dict((i, options[i]) for i in keys if options.get(i))

Powered by Google App Engine
This is Rietveld 408576698