Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8455)

Unified Diff: chrome/common/extensions/extension_file_util_unittest.cc

Issue 8847003: CheckIllegalFilenamesNoUnderscores is now crashing as well on Vista. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_file_util_unittest.cc
diff --git a/chrome/common/extensions/extension_file_util_unittest.cc b/chrome/common/extensions/extension_file_util_unittest.cc
index e197077164c3e87b3f865bda9f1d0063a5f34aa9..2fb819da7097e51eaaba754060a9477624d62816 100644
--- a/chrome/common/extensions/extension_file_util_unittest.cc
+++ b/chrome/common/extensions/extension_file_util_unittest.cc
@@ -17,8 +17,11 @@
namespace keys = extension_manifest_keys;
+#if defined(OS_WIN)
// http://crbug.com/106381
-TEST(ExtensionFileUtil, DISABLED_InstallUninstallGarbageCollect) {
+#define InstallUninstallGarbageCollect DISABLED_InstallUninstallGarbageCollect
+#endif
+TEST(ExtensionFileUtil, InstallUninstallGarbageCollect) {
ScopedTempDir temp;
ASSERT_TRUE(temp.CreateUniqueTempDir());
@@ -103,6 +106,11 @@ TEST(ExtensionFileUtil, LoadExtensionWithoutLocalesFolder) {
EXPECT_TRUE(error.empty());
}
+#if defined(OS_WIN)
+// http://crbug.com/106381
+#define CheckIllegalFilenamesNoUnderscores \
+ DISABLED_CheckIllegalFilenamesNoUnderscores
+#endif
TEST(ExtensionFileUtil, CheckIllegalFilenamesNoUnderscores) {
ScopedTempDir temp;
ASSERT_TRUE(temp.CreateUniqueTempDir());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698