Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8846001: Add iterator range constructors to StringPiece. (Closed)

Created:
9 years ago by erikwright (departed)
Modified:
8 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, Paweł Hajdan Jr., jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add iterator range constructors to StringPiece. BUG=87634 TEST=

Patch Set 1 #

Patch Set 2 : Remove extra blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M base/string_piece.h View 1 3 chunks +20 lines, -0 lines 0 comments Download
M base/string_piece_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
erikwright (departed)
Hi Brett, This, of course, depends upon http://codereview.chromium.org/8659047/ . Thanks, Erik
9 years ago (2011-12-07 15:34:10 UTC) #1
brettw
9 years ago (2011-12-12 22:42:29 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698