Send notifications to off-the-record profile about error bubble being added/removed.

Send notifications to off-the-record profile about error bubble being added/removed.

R=sail@chromium.org
BUG=106466
TEST=Modify Web Data file to trigger Protector bubble, launch Chrome, open Incognito window, wait for 10 minutes or dismiss the bubble with any button, verify that wrench menu button doesn't have Protector badge anymore.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113780

[sail, 2011-12-07 16:18:29]

What do you think of changing Global Errors so that they don't show on incognito
windows by default? A simple way to do this would be to change:
GlobalErrorServiceFactory::ServiceRedirectedInIncognito() to return false.

If you don't think that's a good fix then change you add a DCHECK() that
GlobalErrorServiceFactory::ServiceRedirectedInIncognito() returns true in your
new code?

Thanks

[whywhat, 2011-12-08 10:22:35]

On 2011/12/07 16:18:29, sail wrote:
> What do you think of changing Global Errors so that they don't show on
incognito
> windows by default? A simple way to do this would be to change:
> GlobalErrorServiceFactory::ServiceRedirectedInIncognito() to return false.
> 
> If you don't think that's a good fix then change you add a DCHECK() that
> GlobalErrorServiceFactory::ServiceRedirectedInIncognito() returns true in your
> new code?
> 
> Thanks

I'd rather see errors in both incognito and normal windows. Is there a reason
that global errors weren't supported properly for incognito windows?

[sail, 2011-12-08 17:43:26]

On 2011/12/08 10:22:35, whywhat wrote:
> On 2011/12/07 16:18:29, sail wrote:
> > What do you think of changing Global Errors so that they don't show on
> incognito
> > windows by default? A simple way to do this would be to change:
> > GlobalErrorServiceFactory::ServiceRedirectedInIncognito() to return false.
> > 
> > If you don't think that's a good fix then change you add a DCHECK() that
> > GlobalErrorServiceFactory::ServiceRedirectedInIncognito() returns true in
your
> > new code?
> > 
> > Thanks
> 
> I'd rather see errors in both incognito and normal windows. Is there a reason
> that global errors weren't supported properly for incognito windows?

I never thought through the incognito case for error bubbles.

[sail, 2011-12-08 17:44:45]

lgtm

http://codereview.chromium.org/8844003/diff/4001/chrome/browser/ui/global_err...
File chrome/browser/ui/global_error_service.cc (right):

http://codereview.chromium.org/8844003/diff/4001/chrome/browser/ui/global_err...
chrome/browser/ui/global_error_service.cc:64: std::vector<Profile*>
profiles_to_notify;
can you add a DCHECK() for ServiceRedirectedInIncognito().

Also can you add a comment that you need to broadcast 2 set of notifications so
that both normal windows and incognito windows get updated.

[whywhat, 2011-12-09 11:14:33]

http://codereview.chromium.org/8844003/diff/4001/chrome/browser/ui/global_err...
File chrome/browser/ui/global_error_service.cc (right):

http://codereview.chromium.org/8844003/diff/4001/chrome/browser/ui/global_err...
chrome/browser/ui/global_error_service.cc:64: std::vector<Profile*>
profiles_to_notify;
I've added comment. How can I check ServiceRedirectedInIncognito here if it's
private in the factory class?

On 2011/12/08 17:44:45, sail wrote:
> can you add a DCHECK() for ServiceRedirectedInIncognito().
> 
> Also can you add a comment that you need to broadcast 2 set of notifications
so
> that both normal windows and incognito windows get updated.

[sail, 2011-12-09 17:43:51]

lgtm

http://codereview.chromium.org/8844003/diff/4001/chrome/browser/ui/global_err...
File chrome/browser/ui/global_error_service.cc (right):

http://codereview.chromium.org/8844003/diff/4001/chrome/browser/ui/global_err...
chrome/browser/ui/global_error_service.cc:64: std::vector<Profile*>
profiles_to_notify;
On 2011/12/09 11:14:33, whywhat wrote:
> I've added comment. How can I check ServiceRedirectedInIncognito here if it's
> private in the factory class?
> 
> On 2011/12/08 17:44:45, sail wrote:
> > can you add a DCHECK() for ServiceRedirectedInIncognito().
> > 
> > Also can you add a comment that you need to broadcast 2 set of notifications
> so
> > that both normal windows and incognito windows get updated.
> 

Ahh damn, never mind.