Sync parser and preparser on do-while and return statements.

Sync parser and preparser on do-while and return statements.

This CL fixes the preparser to have the same liberal automatic semicolon
insertion behaviour as the parser. In the case of a return statement in
global code we throw a syntax error at runtime rather than an early error
due to compatibility with KJS. However that hack allowed the following
syntactically incorrect program in global code in the parser but not in
the preparser:
  if (false) return else {}
while the slightly saner version with the obligatory semicolon
  if (false) return; else {}
was disallowed in the parser, but the preparser allowed it. This CL also
fixes that issue.

BUG=v8:1856
TEST=cctest/test-parsing.cc

Committed: http://code.google.com/p/v8/source/detail?r=10201

[Steven, 2011-12-07 15:32:22]

PTAL.

[Yang, 2011-12-07 15:59:22]

On 2011/12/07 15:32:22, Steven wrote:
> PTAL.

LGTM with nits.

[Yang, 2011-12-07 15:59:33]

Forgot to send the nits...

http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:976: 
Presubmit check says

test/cctest/test-parsing.cc:975:  Using sizeof(type).  Use sizeof(varname)
instead if possible  [runtime/sizeof] [1]

http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:1071: int length = i::OS::SNPrintF( program,
Presubmit says

test/cctest/test-parsing.cc:1071:  Extra space after ( in function call 
[whitespace/parens] [4]

[Steven, 2011-12-07 16:03:08]

http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:976: 
On 2011/12/07 15:59:33, Yang wrote:
> Presubmit check says
> 
> test/cctest/test-parsing.cc:975:  Using sizeof(type).  Use sizeof(varname)
> instead if possible  [runtime/sizeof] [1]

Done.

http://codereview.chromium.org/8844002/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:1071: int length = i::OS::SNPrintF( program,
On 2011/12/07 15:59:33, Yang wrote:
> Presubmit says
> 
> test/cctest/test-parsing.cc:1071:  Extra space after ( in function call 
> [whitespace/parens] [4]

Done.