Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: webkit/tools/test_shell/run_all_tests.cc

Issue 8844001: Setup TestShellPlatformDelegate before MessageLoop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/run_all_tests.cc
diff --git a/webkit/tools/test_shell/run_all_tests.cc b/webkit/tools/test_shell/run_all_tests.cc
index 176f8b9bdcd0d1edab68098971bfc90feb8cad76..5b1cc453ff1f3c57ed32f93d7d482ae58912e4e8 100644
--- a/webkit/tools/test_shell/run_all_tests.cc
+++ b/webkit/tools/test_shell/run_all_tests.cc
@@ -44,8 +44,8 @@ class TestShellTestSuite : public base::TestSuite {
public:
TestShellTestSuite(int argc, char** argv)
: base::TestSuite(argc, argv),
- test_shell_webkit_init_(true),
- platform_delegate_(*CommandLine::ForCurrentProcess()) {
+ platform_delegate_(*CommandLine::ForCurrentProcess()),
+ test_shell_webkit_init_(true) {
}
virtual void Initialize() {
@@ -93,6 +93,8 @@ class TestShellTestSuite : public base::TestSuite {
}
private:
+ TestShellPlatformDelegate platform_delegate_;
+
// Allocate a message loop for this thread. Although it is not used
// directly, its constructor sets up some necessary state.
MessageLoopForUI main_message_loop_;
@@ -100,8 +102,6 @@ class TestShellTestSuite : public base::TestSuite {
// Initialize WebKit for this scope.
TestShellWebKitInit test_shell_webkit_init_;
- TestShellPlatformDelegate platform_delegate_;
-
DISALLOW_COPY_AND_ASSIGN(TestShellTestSuite);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698