Setup TestShellPlatformDelegate before MessageLoop.

Setup TestShellPlatformDelegate before MessageLoop.

MessagePumpMac wants NSApp to be initialized before the UI MessageLoop
is created.

BUG=102224
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113437

[Scott Hess - ex-Googler, 2011-12-07 15:33:46]

My earlier change http://codereview.chromium.org/8771028/ added a requirement
that NSApplication be initialized before the main UI MessageLoop is created.  I
could loosen that, but I think it's a good idea in general.  In this case, the
MessageLoop is being setup as part of the constructor, so I re-ordered the
member variables.  It works on Mac, and AFAICT from reading the code,
TestShellPlatformDelegate's constructor doesn't do anything odd (Win registers
some CRT stuff, Gtk is empty, actually Mac does the most).

Another option would be to make the MessageLoop a scoped_ptr and explicitly
order the initialization that way.

base::TestSuite does the NSApp setup in Initialize().  That may also be an
option, but I'd have to look into InitWebCoreSystemInterface() to be sure.

I could also call RegisterMockCrApp() manually in main(), which would work, but
seems like the entire point of the platform delegate in the first place.

[Scott Hess - ex-Googler, 2011-12-07 15:37:42]

On 2011/12/07 15:33:46, shess wrote:
> My earlier change http://codereview.chromium.org/8771028/ added a requirement
> that NSApplication be initialized before the main UI MessageLoop is created. 
I
> could loosen that, but I think it's a good idea in general.

Mark, just to clarify, this is why you're here :-).  Maybe that requirement is
way wrong.  In which case I might have to put back some
"RegisterCrAppHereBecauseIHaveTo" cases.

[Mark Mentovai, 2011-12-07 16:13:26]

That requirement is fine. LGTM.

[tony, 2011-12-07 17:44:02]

LGTM2

[commit-bot: I haz the power, 2011-12-07 18:02:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/8844001/1

[commit-bot: I haz the power, 2011-12-07 19:23:17]

Change committed as 113437