Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 8842002: Remove lock screen item from menu and disable screen lock on guest session. (Closed)

Created:
9 years ago by flackr
Modified:
9 years ago
Reviewers:
achuithb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Rick Byers
Visibility:
Public.

Description

Remove lock screen item from menu and disable screen lock on guest session. BUG=chromium-os:23764 TEST=Log in as guest, attempt to lock screen, nothing should happen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113485

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change VLOG to DVLOG in ScreenLocker::Show. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/chromeos/login/screen_locker.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
Achuith, I see you added the menu item to lock the screen. Does it make ...
9 years ago (2011-12-07 16:08:50 UTC) #1
achuithb
LGTM provided nit below is taken care of. http://codereview.chromium.org/8842002/diff/1/chrome/browser/chromeos/login/screen_locker.cc File chrome/browser/chromeos/login/screen_locker.cc (right): http://codereview.chromium.org/8842002/diff/1/chrome/browser/chromeos/login/screen_locker.cc#newcode359 chrome/browser/chromeos/login/screen_locker.cc:359: VLOG(1) ...
9 years ago (2011-12-07 18:46:02 UTC) #2
achuithb
Thanks for fixing this, Robert! On 2011/12/07 18:46:02, achuith.bhandarkar wrote: > LGTM provided nit below ...
9 years ago (2011-12-07 18:47:25 UTC) #3
flackr
http://codereview.chromium.org/8842002/diff/1/chrome/browser/chromeos/login/screen_locker.cc File chrome/browser/chromeos/login/screen_locker.cc (right): http://codereview.chromium.org/8842002/diff/1/chrome/browser/chromeos/login/screen_locker.cc#newcode359 chrome/browser/chromeos/login/screen_locker.cc:359: VLOG(1) << "Show: Refusing to lock screen for guest ...
9 years ago (2011-12-07 19:05:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/8842002/1002
9 years ago (2011-12-07 21:06:12 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-07 22:27:34 UTC) #6
Change committed as 113485

Powered by Google App Engine
This is Rietveld 408576698