Issue 884003: Fix mac unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 884003: Fix mac unit tests (Closed)

Created:
10 years, 9 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix mac unit tests TBR=trungl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41419

Patch Set 1 #

Total comments: 3

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View		1 chunk	+8 lines, -6 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

10 years, 9 months ago (2010-03-12 08:11:28 UTC) #2

LG or whatever.

http://codereview.chromium.org/884003/diff/1/2
File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (right):

http://codereview.chromium.org/884003/diff/1/2#newcode262
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:262: // Make the window
fit on screen, with a distance of at least |padding| to
That should've been "*from* the sides". Stupid prepositions.

http://codereview.chromium.org/884003/diff/1/2#newcode264
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:264: if ([[self window]
screen]) {  // nil in unit tests
Possibly also nil under other strange situations, IIRC.

http://codereview.chromium.org/884003/diff/1/2#newcode266
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:266: NSRect screen =
[[[self window] screen] frame];
Did you rename it so that things would still fit on single lines? <shrug>

Expand Messages | Collapse Messages