Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ppapi/tests/test_udp_socket_private_shared.cc

Issue 8840007: GetDocumentURL is added to PPB_Testing_Dev. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed codereview issues. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_udp_socket_private_shared.h ('k') | ppapi/tests/test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_udp_socket_private_shared.cc
diff --git a/ppapi/tests/test_udp_socket_private_shared.cc b/ppapi/tests/test_udp_socket_private_shared.cc
index 192f00f96eca0f488e4382ba3400ad62982b4da8..da97caebc65b8f84abfd652fb75f669d519896de 100644
--- a/ppapi/tests/test_udp_socket_private_shared.cc
+++ b/ppapi/tests/test_udp_socket_private_shared.cc
@@ -11,10 +11,6 @@
REGISTER_TEST_CASE(UDPSocketPrivateShared);
-// TODO(ygorshenin): get rid of using external server in tests,
-// http://crbug.com/105863
-const char* const TestUDPSocketPrivateShared::kHost = "www.google.com";
-
TestUDPSocketPrivateShared::TestUDPSocketPrivateShared(
TestingInstance* instance)
: TestCase(instance),
@@ -33,7 +29,15 @@ bool TestUDPSocketPrivateShared::Init() {
if (!udp_socket_private_interface_)
instance_->AppendError("UDPSocketPrivate interface not available");
- return tcp_socket_private_interface_ && udp_socket_private_interface_ &&
+ bool init_host_port = false;
+ if (!GetLocalHostPort(instance_->pp_instance(), &host_, &port_))
+ instance_->AppendError("Can't init host and port");
+ else
+ init_host_port = true;
+
+ return tcp_socket_private_interface_ &&
+ udp_socket_private_interface_ &&
+ init_host_port &&
InitTestingInterface();
}
@@ -54,7 +58,7 @@ std::string TestUDPSocketPrivateShared::GenerateNetAddress(
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
int32_t rv = tcp_socket_private_interface_->Connect(
- *socket, kHost, kPort,
+ *socket, host_.c_str(), port_,
static_cast<pp::CompletionCallback>(callback).pp_completion_callback());
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
return ReportError("PPB_TCPSocket_Private::Connect force_async", rv);
« no previous file with comments | « ppapi/tests/test_udp_socket_private_shared.h ('k') | ppapi/tests/test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698