Replace ProfileManagerObserver with callback

chrome/browser/chromeos/login/login_performer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_PERFORMER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_PERFORMER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 34 matching lines @@
 // If |delegate_| is NULL that does mean that LoginPerformer instance
 // is waiting for successful online login or blocked on online login failure.
 // In case of failure password/captcha
 // input & error messages display is dedicated to ScreenLocker instance.
 //
 // 2 things make LoginPerfrormer instance exist longer:
 // 1. ScreenLock active (pending correct new password input)
 // 2. Pending online auth request.
 class LoginPerformer : public LoginStatusConsumer,
                        public content::NotificationObserver,
-                       public ProfileManagerObserver {
+                       public base::SupportsWeakPtr<LoginUtilsImpl> {

[Robert Sesek, 2011/12/07 16:36:13]

This class already holds a WeakPtrFactory weak_factory_. I don't think you need
this (also, this seems like the wrong template param).

[sail, 2011/12/07 17:18:13]

Done.

  public:
   // Delegate class to get notifications from the LoginPerformer.
   class Delegate : public LoginStatusConsumer {
    public:
     virtual ~Delegate() {}
     virtual void WhiteListCheckFailed(const std::string& email) = 0;
   };
 
   explicit LoginPerformer(Delegate* delegate);
   virtual ~LoginPerformer();
@@ skipping 53 matching lines @@
     AUTH_MODE_EXTENSION
   } AuthorizationMode;
   AuthorizationMode auth_mode() const { return auth_mode_; }
 
  private:
   // content::NotificationObserver implementation:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
-  // ProfileManagerObserver implementation:
-  virtual void OnProfileCreated(Profile* profile, Status status) OVERRIDE;
+  // Callback for asynchronous profile creation.
+  void OnProfileCreated(Profile* profile,
+                        Profile::CreateStatus status);
 
   // Requests screen lock and subscribes to screen lock notifications.
   void RequestScreenLock();
 
   // Requests screen unlock.
   void RequestScreenUnlock();
 
   // Resolves initial LoginFailure::NETWORK_AUTH_FAILED error i.e.
   // when screen is not locked yet.
   void ResolveInitialNetworkAuthFailure();
@@ skipping 66 matching lines @@
   bool using_oauth_;
 
   base::WeakPtrFactory<LoginPerformer> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginPerformer);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_PERFORMER_H_