Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 8840002: (Chrome OS) Notify when the candidate window is opened/closed. (Closed)

Created:
9 years ago by falken
Modified:
9 years ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

(Chrome OS) Notify when the candidate window is opened/closed. This will allow for IME/omnibox coordination, as the omnibox can observe when the candidate window is open. Currently, there is no distinction between the suggest window and candidate window in these events, but it can be changed later. BUG=chromium-os:17763 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113572

Patch Set 1 #

Patch Set 2 : remove unused header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -5 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 7 chunks +53 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.h View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 7 chunks +41 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
This is a step toward IME/omnibox coordination on Cros. This change will allow the omnibox ...
9 years ago (2011-12-07 06:40:54 UTC) #1
Yusuke Sato
LGTM On 2011/12/07 06:40:54, falken wrote: > This is a step toward IME/omnibox coordination on ...
9 years ago (2011-12-08 06:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/8840002/8
9 years ago (2011-12-08 06:35:16 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-08 07:51:58 UTC) #4
Change committed as 113572

Powered by Google App Engine
This is Rietveld 408576698