Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 8840001: NTP4: Remove gradient while printing most visited thumbnails. (Closed)

Created:
9 years ago by Dan Beam
Modified:
9 years ago
Reviewers:
csilv, Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

NTP4: Remove gradient while printing most visited thumbnails. There is currently a bug in WebKit that renders -webkit-linear-gradient() differently across platforms when trying to print (shows no gradient on Linux/Win, shows gradient without alpha on Mac?), so we'll just remove the gradient when users are printing the Most Visited section of the NTP so they can see their pretty thumbnails. Upstream WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=19942 R=estade@chromium.org TBR=csilv@chromium.org TEST=Print preview shows Most Visited tiles on all platforms. BUG=103443 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113364

Patch Set 1 #

Patch Set 2 : there are issues on more than one platform, not just MacOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/ntp4/most_visited_page.css View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
9 years ago (2011-12-07 05:04:45 UTC) #1
Evan Stade
lgtm I guess I could really care less about printing the ntp though
9 years ago (2011-12-07 06:18:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/8840001/4001
9 years ago (2011-12-07 07:06:00 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-07 08:13:01 UTC) #4
Change committed as 113364

Powered by Google App Engine
This is Rietveld 408576698