Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: client/html/src/ElementWrappingImplementation.dart

Issue 8839010: New version of the bindings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/src/DocumentWrappingImplementation.dart ('k') | client/html/src/GlobalProperties.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/ElementWrappingImplementation.dart
diff --git a/client/html/src/ElementWrappingImplementation.dart b/client/html/src/ElementWrappingImplementation.dart
index b5e3a752cc0b4876a31cf8f186656c85c7cd598f..6920b010e207ceb22342b0e56ca9eb12b1b4c4f1 100644
--- a/client/html/src/ElementWrappingImplementation.dart
+++ b/client/html/src/ElementWrappingImplementation.dart
@@ -454,7 +454,7 @@ class ElementRectWrappingImplementation implements ElementRect {
// This should be type dom.ClientRect but that fails on dartium. b/5522629
final _boundingClientRect;
// an exception due to a dartium bug.
- final dom.ClientRectList _clientRects;
+ final _clientRects; // TODO(jacobr): should be dom.ClientRectList
ElementRectWrappingImplementation(dom.HTMLElement element) :
client = new SimpleClientRect(element.clientLeft,
@@ -518,7 +518,8 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
parentTag = _CUSTOM_PARENT_TAG_MAP[tag];
}
}
- final temp = dom.document.createElement(parentTag);
+ // TODO(jacobr): make type dom.HTMLElement when dartium allows it.
+ var temp = dom.document.createElement(parentTag);
temp.innerHTML = html;
if (temp.childElementCount == 1) {
« no previous file with comments | « client/html/src/DocumentWrappingImplementation.dart ('k') | client/html/src/GlobalProperties.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698