Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 8839004: Release slotId of TouchEvent when USE_XI2_MT defined (Closed)

Created:
9 years ago by aofdwsl
Modified:
9 years ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

Release slotId of TouchEvent when USE_XI2_MT defined When defined USE_XI2_MT, slot id of TouchEvent is maintained by a map of tracking id to slot id. Because tracking id will always keep increasing. The item should be released by TouchRelease to free the slot id for future use. BUG=106673 TEST=Manually Tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113850

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix style nit and add name to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/x/events_x.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aofdwsl
Please review the patch, Thanks.
9 years ago (2011-12-07 07:41:09 UTC) #1
aofdwsl
Please review the patch, thanks.
9 years ago (2011-12-07 09:25:24 UTC) #2
sadrul
A small style nit. Otherwise, LGTM. Thanks! I notice that you are not in AUTHORS ...
9 years ago (2011-12-08 17:04:41 UTC) #3
aofdwsl
Thanks, I've fixed the nit according to you comments.
9 years ago (2011-12-09 01:54:56 UTC) #4
sky
LGTM
9 years ago (2011-12-09 16:27:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aofdwsl@gmail.com/8839004/5001
9 years ago (2011-12-09 16:27:51 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-09 22:10:42 UTC) #7
Change committed as 113850

Powered by Google App Engine
This is Rietveld 408576698