WebSocket Pepper API: validate redundant protocols in Connect()

WebSocket Pepper API: validate redundant protocols in Connect()

Given protocols argument is not allowed to have any duplicated protocol
name in Connect().

This CL contains constant number replacement in test_websocket.cc like
s/0/0U/g, and detailed comments on protocols argument check.

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_Protocols'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113760

[Takashi Toyoshima, 2011-12-07 07:11:10]

Small CL to remove a TODO.

[dmichael (off chromium), 2011-12-07 20:21:13]

http://codereview.chromium.org/8839003/diff/1/webkit/plugins/ppapi/ppb_websoc...
File webkit/plugins/ppapi/ppb_websocket_impl.cc (right):

http://codereview.chromium.org/8839003/diff/1/webkit/plugins/ppapi/ppb_websoc...
webkit/plugins/ppapi/ppb_websocket_impl.cc:151: base::DictionaryValue
protocol_set;
Why not just use std::set? This seems like overkill to me. You don't need any
depth and you don't need to be able to serialize this.

[Takashi Toyoshima, 2011-12-08 05:12:46]

Thank you for good advice.
I replace DictionaryValue with set<string>.

Thanks!

http://codereview.chromium.org/8839003/diff/1/webkit/plugins/ppapi/ppb_websoc...
File webkit/plugins/ppapi/ppb_websocket_impl.cc (right):

http://codereview.chromium.org/8839003/diff/1/webkit/plugins/ppapi/ppb_websoc...
webkit/plugins/ppapi/ppb_websocket_impl.cc:151: base::DictionaryValue
protocol_set;
Oh, that's right.
I misunderstood about std::set<std::string>.
I use it instead of DictionaryValue.

[dmichael (off chromium), 2011-12-08 18:43:49]

lgtm

[commit-bot: I haz the power, 2011-12-09 04:05:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8839003/5001

[commit-bot: I haz the power, 2011-12-09 04:05:22]

Presubmit check for 8839003-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: webkit/plugins/ppapi/ppb_websocket_impl.cc

Presubmit checks took 1.5s to calculate.

[piman, 2011-12-09 08:06:40]

lgtm