Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 8839001: Revert 113321 (speculative revert for http://crbug.com/106657 and a few other problems) (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 113321 (speculative revert for http://crbug.com/106657 and a few other problems) - Provide windows notifictaion of thread termination Provide an automatic fallback scan of the linker list of notifcation callbacks via DllMain. This fallback is ONLY used if there are no notifications coming via the linker list. This allows all existing code to continue working as it does today, and provides thread teardown notifcatino on XP even though we use the LoadLibrary call. It is a minimal change, suitable for pushing to other channels (beta? stable?). r=cpu BUG=103209 Review URL: http://codereview.chromium.org/8550009 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -133 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D base/win/dllmain.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
9 years ago (2011-12-07 03:54:26 UTC) #1
Nico
9 years ago (2011-12-07 04:54:24 UTC) #2
This revert helped. It fixed nacl_integration on the waterfall, and ui_tests on
the xp bots. For example:
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%283%29/builds/724...
:

WorkerTest.SingleSharedWorker: 
.\test\automation\proxy_launcher.cc(287): error: Value of: exit_code
  Actual: -2147483645
Expected: 0
.\test\ui\ui_test.cc(150): error: Value of: assertions.size()
  Actual: 2
Expected: expected_errors_
Which is: 0
The following error(s) occurred in the application during this test:

[3108:1016:1473140:FATAL:dllmain.cc(116)] Check failed: *it >
p_thread_callback_dllmain_later_entry (00000000 vs. 01C36800)

[3108:1016:1473578:FATAL:dllmain.cc(116)] Check failed: *it >
p_thread_callback_dllmain_later_entry (00000000 vs. 01C36800)
.\test\ui\ui_test.cc(160): error: Value of: actual_crashes
  Actual: 2
Expected: expected_crashes_
Which is: 0
Encountered an unexpected crash in the program during this test.

Powered by Google App Engine
This is Rietveld 408576698