Issue 8836004: Removing valgrind memcheck suppressions for a few FFmpeg-related functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8836004: Removing valgrind memcheck suppressions for a few FFmpeg-related functions. (Closed)

Created:
9 years ago by scherkus (not reviewing)

Modified:
9 years ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing valgrind memcheck suppressions for a few FFmpeg-related functions. The stack traces on these have been incorrect for quite some time. Doing logs analysis on mac/linux media_unittests and layout test results also show that these suppressions haven't been used in the last ~200 runs. BUG=32360, 93932, 102016 TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113357

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -51 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1	3 chunks	+0 lines, -51 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rbultje1

On 2011/12/07 07:03:45, scherkus wrote: The middle suppression was fixed by the pthread.c change in: ...

9 years ago (2011-12-07 17:01:11 UTC) #2

LGTM

Expand Messages | Collapse Messages