Add syzygy files to archives and symbol processing.

Add syzygy files to archives and symbol processing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113482

[Sigurður Ásgeirsson, 2011-12-07 14:30:35]

lgtm, thanks!

http://codereview.chromium.org/8836001/diff/1/chrome/tools/build/win/FILES.cfg
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/8836001/diff/1/chrome/tools/build/win/FILES.cf...
chrome/tools/build/win/FILES.cfg:16: # archive: The name of the archive file to
store filename in. If not specified,
Nice!

[nsylvain, 2012-04-06 01:21:12]

Hello.

This change adds ~100MB to the archive of the chromium builds.  This used to not
be a big deal because it was fast, but now it takes close to 25 minutes to
upload our 500MB archive to google storage, and this is slowing down the cycle
of the "Win" bot on the main waterfall considerably.  

Is this really needed for chromium builds?

thanks!

[Sigurður Ásgeirsson, 2012-04-06 02:57:59]

I don't think we want to archive these files except for official builds.
The chromium files are randomized, and serve only as a smoke test.

On Thu, Apr 5, 2012 at 21:21, <nsylvain@google.com> wrote:

> Hello.
>
> This change adds ~100MB to the archive of the chromium builds.  This used
> to not
> be a big deal because it was fast, but now it takes close to 25 minutes to
> upload our 500MB archive to google storage, and this is slowing down the
> cycle
> of the "Win" bot on the main waterfall considerably.
>
> Is this really needed for chromium builds?
>
> thanks!
>
>
http://codereview.chromium.**org/8836001/<http://codereview.chromium.org/8836...
>

[Michael Moss, 2012-04-06 03:33:20]

Unlike FILES.cfg, SYMBOLS doesn't distinguish between official and non.
Maybe this is reason to finally bite the bullet and transition all these
file lists to the FILES.cfg format. I can start working on it if that's
what we want.
On Apr 5, 2012 7:57 PM, "Sigurður Ásgeirsson" <siggi@chromium.org> wrote:

> I don't think we want to archive these files except for official builds.
> The chromium files are randomized, and serve only as a smoke test.
>
> On Thu, Apr 5, 2012 at 21:21, <nsylvain@google.com> wrote:
>
>> Hello.
>>
>> This change adds ~100MB to the archive of the chromium builds.  This used
>> to not
>> be a big deal because it was fast, but now it takes close to 25 minutes to
>> upload our 500MB archive to google storage, and this is slowing down the
>> cycle
>> of the "Win" bot on the main waterfall considerably.
>>
>> Is this really needed for chromium builds?
>>
>> thanks!
>>
>>
http://codereview.chromium.**org/8836001/<http://codereview.chromium.org/8836...
>>
>
>

[nsylvain, 2012-04-06 05:09:55]

On 2012/04/06 03:33:20, Michael Moss wrote:
> Unlike FILES.cfg, SYMBOLS doesn't distinguish between official and non.
> Maybe this is reason to finally bite the bullet and transition all these
> file lists to the FILES.cfg format. I can start working on it if that's
> what we want.

That would certainly be great to be able to not archive those files for
chromium, but I don't know how much work it is, so I'm not sure about the
tradeoff.  I'm open to anything, and will continue looking at the reasons why gs
upload is so slow.

thanks
> On Apr 5, 2012 7:57 PM, "Sigurður Ásgeirsson" <mailto:siggi@chromium.org>
wrote:
> 
> > I don't think we want to archive these files except for official builds.
> > The chromium files are randomized, and serve only as a smoke test.
> >
> > On Thu, Apr 5, 2012 at 21:21, <mailto:nsylvain@google.com> wrote:
> >
> >> Hello.
> >>
> >> This change adds ~100MB to the archive of the chromium builds.  This used
> >> to not
> >> be a big deal because it was fast, but now it takes close to 25 minutes to
> >> upload our 500MB archive to google storage, and this is slowing down the
> >> cycle
> >> of the "Win" bot on the main waterfall considerably.
> >>
> >> Is this really needed for chromium builds?
> >>
> >> thanks!
> >>
> >>
>
http://codereview.chromium.**org/8836001/%3Chttp://codereview.chromium.org/88...>
> >>
> >
> >