Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tests/standalone/src/TestRunnerTest.dart

Issue 8835010: Support --special-command test option. As a special case support --valgrind option. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comment. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/stub-generator/test_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/TestRunnerTest.dart
diff --git a/tests/standalone/src/TestRunnerTest.dart b/tests/standalone/src/TestRunnerTest.dart
index b5f1f99659988dcd2f2dfb5f3d90dd95407837ca..b7c0fac6067eff0b42c33c6ee4b22e3b1f21c90b 100644
--- a/tests/standalone/src/TestRunnerTest.dart
+++ b/tests/standalone/src/TestRunnerTest.dart
@@ -43,20 +43,22 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
test_path = "../tests/standalone/src/${testName}.dart";
}
- var timeout = 2;
+ var configuration = { 'timeout': 2,
+ 'special-command': '' };
return new TestCase(testName,
getDartFileName(),
<String>["--ignore-unrecognized-flags",
"--enable_type_checks",
test_path],
- timeout,
+ configuration,
TestController.processCompletedTest,
new Set<String>.from(expectations));
}
void main() {
- int timeout = 2;
+ var configuration = { 'timeout': 2,
+ 'special-command': '' };
new RunningProcess(MakeTestCase("PassTest", [PASS])).start();
new RunningProcess(MakeTestCase("FailTest", [FAIL])).start();
new RunningProcess(MakeTestCase("TimeoutTest", [TIMEOUT])).start();
@@ -64,7 +66,7 @@ void main() {
new RunningProcess(new TestCase("CrashTest",
getProcessTestFileName(),
const ["0", "0", "1", "1"],
- timeout,
+ configuration,
TestController.processCompletedTest,
new Set<String>.from([CRASH]))).start();
Expect.equals(4, TestController.numTests);
« no previous file with comments | « no previous file | tests/stub-generator/test_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698