Support --special-command test option. As a special case support --valgrind option.

tools/testing/dart/test_options.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_options_parser");
 
 List<String> defaultTestSelectors =
     const ['dartc', 'samples', 'standalone', 'corelib', 'co19', 'language',
            'isolate', 'stub-generator', 'vm'];
 
@@ skipping 16 matching lines @@
   List<String> values;
   var defaultValue;
   String type;
 }
 
 
 /**
  * Parser of test options.
  */
 class TestOptionsParser {
+  String specialCommandHelp =
+"""
+Special command support. Wraps the command line in
+a special command. The special command should contain
+an '@' character which will be replaced by the normal
+command.
+
+For example if the normal command that will be executed
+is 'dart file.dart' and you specify special command
+'python -u valgrind.py @ suffix' the final command will be
+'python -u valgrind.py dart file.dart suffix'""";
+
   /**
    * Creates a test options parser initialized with the known options.
    */
   TestOptionsParser() {
     _options =
         [ new _TestOptionSpecification(
               'mode',
               'Mode in which to run the tests',
               ['-m', '--mode'],
               ['all', 'debug', 'release'],
@@ skipping 31 matching lines @@
               -1,
               'int'),
           new _TestOptionSpecification(
               'progress',
               'Progress indication mode',
               ['-p', '--progress'],
               ['compact', 'color', 'line', 'verbose', 'status', 'buildbot'],
               'compact'),
           new _TestOptionSpecification(
               'report',
-              'Print a summary report of the number of tests, by expectation.',
+              'Print a summary report of the number of tests, by expectation',
               ['--report'],
               [],
               false,
               'bool'),
           new _TestOptionSpecification(
               'tasks',
               'The number of parallel tasks to run',
               ['-j', '--tasks'],
               [],
               new Platform().numberOfProcessors(),
               'int'),
           new _TestOptionSpecification(
               'help',
               'Print list of options',
               ['-h', '--help'],
               [],
               false,
               'bool'),
           new _TestOptionSpecification(
               'verbose',
               'Verbose output',
               ['-v', '--verbose'],
               [],
               false,
-              'bool')];
+              'bool'),
+          new _TestOptionSpecification(
+              'valgrind',
+              'Run tests through valgrind',
+              ['--valgrind'],
+              [],
+              false,
+              'bool'),
+          new _TestOptionSpecification(
+              'special-command',
+              specialCommandHelp,
+              ['--special-command'],
+              [],
+              '')];
   }
 
 
   /**
    * Parse a list of strings as test options.
    *
    * Returns a list of configurations in which to run the
    * tests. Configurations are maps mapping from option keys to
    * values. When encountering the first non-option string, the rest
    * of the arguments are stored in the returned Map under the 'rest'
@@ skipping 105 matching lines @@
     // Expand the pseudo-values such as 'all'.
     if (configuration['arch'] == 'all') {
       configuration['arch'] = 'ia32,x64,simarm';
     }
     if (configuration['mode'] == 'all') {
       configuration['mode'] = 'debug,release';
     }
     if (configuration['component'] == 'most') {
       configuration['component'] = 'vm,dartc';
     }
+    if (configuration['valgrind']) {
+      // TODO(ager): Get rid of this when there is only one checkout and
+      // we don't have to special case for the runtime checkout.
+      File valgrindFile = new File('runtime/tools/valgrind.py');
+      if (!valgrindFile.existsSync()) {
+        valgrindFile = new File('../runtime/tools/valgrind.py');
+      }
+      String valgrind = valgrindFile.fullPathSync();
+      configuration['special-command'] = 'python -u $valgrind @';
+    }
 
     // Use verbose progress indication for verbose output.
     if (configuration['verbose']) {
       configuration['progress'] = 'verbose';
     }
 
     // Create the artificial 'unchecked' option that test status files
     // expect.
     configuration['unchecked'] = !configuration['checked'];
 
@@ skipping 133 matching lines @@
       if (option.keys.some((key) => key == name)) {
         return option;
       }
     }
     return null;
   }
 
 
   List<_TestOptionSpecification> _options;
 }