Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 8835005: Aura Task Manager: Remember the dialog size before closing task manager. (Closed)

Created:
9 years ago by NaveenBobbili (Motorola)
Modified:
9 years ago
Reviewers:
yoshiki, James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

Aura Task Manager: Remember the dialog size before closing task manager. BUG=105117 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113560

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/html_dialog_view.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
NaveenBobbili (Motorola)
This patch is specific to Aura framework. The changes for linux are already committed as ...
9 years ago (2011-12-07 07:54:28 UTC) #1
yoshiki
Thank you for the nice patch! LGTM with nit. http://codereview.chromium.org/8835005/diff/1/chrome/browser/ui/views/html_dialog_view.cc File chrome/browser/ui/views/html_dialog_view.cc (right): http://codereview.chromium.org/8835005/diff/1/chrome/browser/ui/views/html_dialog_view.cc#newcode182 chrome/browser/ui/views/html_dialog_view.cc:182: ...
9 years ago (2011-12-07 08:02:50 UTC) #2
NaveenBobbili (Motorola)
Done. Please take a look now. http://codereview.chromium.org/8835005/diff/1/chrome/browser/ui/views/html_dialog_view.cc File chrome/browser/ui/views/html_dialog_view.cc (right): http://codereview.chromium.org/8835005/diff/1/chrome/browser/ui/views/html_dialog_view.cc#newcode182 chrome/browser/ui/views/html_dialog_view.cc:182: gfx::Rect dialog_bounds = ...
9 years ago (2011-12-07 08:14:59 UTC) #3
James Hawkins
LGTM, though I don't think you need my approval for this change.
9 years ago (2011-12-07 17:30:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8835005/4001
9 years ago (2011-12-08 02:14:28 UTC) #5
NaveenBobbili (Motorola)
On 2011/12/07 17:30:51, James Hawkins wrote: > LGTM, though I don't think you need my ...
9 years ago (2011-12-08 02:14:41 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-08 04:23:05 UTC) #7
Change committed as 113560

Powered by Google App Engine
This is Rietveld 408576698