Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: changes/svnpoller.py

Issue 8835004: Add " (CQ)" to the author name if the commit-queue was used. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/build/third_party/buildbot_7_12/buildbot/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: changes/svnpoller.py
===================================================================
--- changes/svnpoller.py (revision 113354)
+++ changes/svnpoller.py (working copy)
@@ -317,7 +317,8 @@
def get_logs(self, ignored_prefix=None):
args = []
- args.extend(["log", "--xml", "--verbose", "--non-interactive"])
+ args.extend(["log", "--xml", "--verbose", "--non-interactive",
M-A Ruel 2011/12/07 17:09:42 Please create a class in scripts/master/ overridin
+ "--with-all-revprops"])
if self.svnuser:
args.extend(["--username=%s" % self.svnuser])
if self.svnpasswd:
@@ -415,6 +416,14 @@
def create_changes(self, new_logentries):
changes = []
+ def commit_bot_used(logentry):
+ revprops = logentry.getElementsByTagName('revprops')
+ if revprops is not None:
+ for revprop in revprops.getElementsByTagName('property'):
+ if revprop.getAttribute("name") == "commit-bot":
+ return True
+ return False
+
for el in new_logentries:
branch_files = [] # get oldest change first
revision = str(el.getAttribute("revision"))
@@ -430,6 +439,11 @@
# values
author = self._get_text(el, "author")
comments = self._get_text(el, "msg")
+
+ # If commit-bot was used, then add (CQ)
+ if commit_bot_used(el):
+ author += " (CQ)"
M-A Ruel 2011/12/07 17:09:42 You can't, as this is used to create the blamelist
+
# there is a "date" field, but it provides localtime in the
# repository's timezone, whereas we care about buildmaster's
# localtime (since this will get used to position the boxes on
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698