Chromium Code Reviews| Index: chrome/browser/extensions/extension_install_ui.cc |
| diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc |
| index 4c926885e1866b521ab0c5d63b618bf340c63dc4..85f5903f5fde81c5112b02ce063c8c9d479506a5 100644 |
| --- a/chrome/browser/extensions/extension_install_ui.cc |
| +++ b/chrome/browser/extensions/extension_install_ui.cc |
| @@ -42,7 +42,7 @@ |
| #include "ui/base/resource/resource_bundle.h" |
| static const int kTitleIds[ExtensionInstallUI::NUM_PROMPT_TYPES] = { |
| - IDS_EXTENSION_INSTALL_PROMPT_TITLE, |
| + 0, |
| IDS_EXTENSION_INLINE_INSTALL_PROMPT_TITLE, |
|
Mihai Parparita -not on Chrome
2011/12/07 04:41:12
If regular installation won't have a title, then i
Evan Stade
2011/12/07 05:54:23
regular installs will have a title. See below.
|
| IDS_EXTENSION_RE_ENABLE_PROMPT_TITLE, |
| IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE |
| @@ -103,8 +103,13 @@ void ExtensionInstallUI::Prompt::SetInlineInstallWebstoreData( |
| rating_count_ = rating_count; |
| } |
| -string16 ExtensionInstallUI::Prompt::GetDialogTitle() const { |
| - if (type_ == INLINE_INSTALL_PROMPT) { |
| +string16 ExtensionInstallUI::Prompt::GetDialogTitle( |
| + const Extension* extension) const { |
| + if (type_ == INSTALL_PROMPT) { |
| + return l10n_util::GetStringUTF16(extension->is_app() ? |
| + IDS_EXTENSION_INSTALL_APP_PROMPT_TITLE : |
| + IDS_EXTENSION_INSTALL_EXTENSION_PROMPT_TITLE); |
| + } else if (type_ == INLINE_INSTALL_PROMPT) { |
| return l10n_util::GetStringFUTF16( |
| kTitleIds[type_], l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)); |
| } else { |