Move CreateFakeXEvent to x11_util.{h,cc}.

Move CreateFakeXEvent to x11_util.{h,cc}.

I'd like to use this function from shell_accelerator_controller_unittest.


BUG=none
TEST=Ran browser_tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113642

[Yusuke Sato, 2011-12-07 16:21:31]

drive-by:
What about moving it to ui/base/x/x11_util.h rather than
keyboard_code_conversion_x.h since the function does not convert anything?

[Daniel Erat, 2011-12-07 16:37:13]

I think I agree that x11_util is a better place for this.

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_x.cc:660: XEvent*
CreateXEventForTesting(EventType type,
rename to CreateXKeyEventForTesting()?

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_x.cc:665: key_event.type =
XKeyEventType(type);
add a CHECK() that type is non-zero?

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_x.cc:680: XEvent* event = new XEvent;
i'd prefer that you passed a pointer to an already-allocated XEvent into this
method; it makes leaks less likely.  InitXKeyEventForTesting() might be a better
name, in that case.

[mazda, 2011-12-08 04:44:28]

yusukes, derat,

Thanks for the suggestion.
I moved the function to x11_util.h.

Please take another look.

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_x.cc:660: XEvent*
CreateXEventForTesting(EventType type,
On 2011/12/07 16:37:13, Daniel Erat wrote:
> rename to CreateXKeyEventForTesting()?

Renamed to InitXKeyEventForTesting.

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_x.cc:665: key_event.type =
XKeyEventType(type);
On 2011/12/07 16:37:13, Daniel Erat wrote:
> add a CHECK() that type is non-zero?

Done.

http://codereview.chromium.org/8834014/diff/5001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_x.cc:680: XEvent* event = new XEvent;
On 2011/12/07 16:37:13, Daniel Erat wrote:
> i'd prefer that you passed a pointer to an already-allocated XEvent into this
> method; it makes leaks less likely.  InitXKeyEventForTesting() might be a
better
> name, in that case.

Done.

[Daniel Erat, 2011-12-08 17:14:23]

lgtm

[commit-bot: I haz the power, 2011-12-08 17:48:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/8834014/8001

[commit-bot: I haz the power, 2011-12-08 17:48:24]

Presubmit check for 8834014-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  ui/base/x/x11_util.cc:907
    void InitXKeyEventForTesting(EventType type,

** Presubmit ERRORS **
Missing LGTM from an OWNER for: ui/base/x/x11_util.h,ui/base/x/x11_util.cc

Presubmit checks took 1.0s to calculate.

[mazda, 2011-12-08 18:09:49]

Adding Ben for OWNERS.
Could you review this change?

[Ben Goodger (Google), 2011-12-08 18:14:57]

lgtm

[commit-bot: I haz the power, 2011-12-08 18:26:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/8834014/8001

[commit-bot: I haz the power, 2011-12-08 19:46:05]

Change committed as 113642