Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: content/browser/renderer_host/java/java_bridge_channel_host.cc

Issue 8834013: Fix a race condition in the Java Bridge when adding objects (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/java/java_bridge_channel_host.cc
diff --git a/content/browser/renderer_host/java/java_bridge_channel_host.cc b/content/browser/renderer_host/java/java_bridge_channel_host.cc
index 1d2141323f60910090605cdcdb9a4d80af08cedc..07ab3f9839554e8dfab11ca26f4a7ef63121efc6 100644
--- a/content/browser/renderer_host/java/java_bridge_channel_host.cc
+++ b/content/browser/renderer_host/java/java_bridge_channel_host.cc
@@ -4,6 +4,7 @@
#include "content/browser/renderer_host/java/java_bridge_channel_host.h"
+#include "base/atomicops.h"
#include "base/lazy_instance.h"
#include "base/stringprintf.h"
#include "base/synchronization/waitable_event.h"
@@ -21,10 +22,13 @@ struct WaitableEventLazyInstanceTraits
};
base::LazyInstance<WaitableEvent, WaitableEventLazyInstanceTraits> dummy_event =
LAZY_INSTANCE_INITIALIZER;
+
+base::subtle::AtomicWord g_last_id = 0;
}
JavaBridgeChannelHost* JavaBridgeChannelHost::GetJavaBridgeChannelHost(
- int renderer_id, base::MessageLoopProxy* ipc_message_loop) {
+ int renderer_id,
+ base::MessageLoopProxy* ipc_message_loop) {
std::string channel_name(StringPrintf("r%d.javabridge", renderer_id));
// We don't use a shutdown event because the Java Bridge only sends messages
// from renderer to browser, so we'll never be waiting for a sync IPC to
@@ -38,9 +42,12 @@ JavaBridgeChannelHost* JavaBridgeChannelHost::GetJavaBridgeChannelHost(
dummy_event.Pointer()));
}
+int JavaBridgeChannelHost::ThreadsafeGenerateRouteID() {
+ return base::subtle::Barrier_AtomicIncrement(&g_last_id, 1);
+}
+
int JavaBridgeChannelHost::GenerateRouteID() {
- static int last_id = 0;
- return ++last_id;
+ return ThreadsafeGenerateRouteID();
}
bool JavaBridgeChannelHost::Init(base::MessageLoopProxy* ipc_message_loop,

Powered by Google App Engine
This is Rietveld 408576698