content/common/java_bridge_messages.h - Issue 8834013: Fix a race condition in the Java Bridge when adding objects

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/java_bridge_messages.h

Issue 8834013: Fix a race condition in the Java Bridge when adding objects (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/renderer_host/java/java_bridge_dispatcher_host.cc ('K') | « content/browser/renderer_host/java/java_bridge_dispatcher_host.cc ('k') | content/renderer/java/java_bridge_dispatcher.h » ('j') | content/renderer/java/java_bridge_dispatcher.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for injected Java objects. See JavaBridgeDispatcher for details.	5 // IPC messages for injected Java objects. See JavaBridgeDispatcher for details.

6	6

7 // Multiply-included message file, hence no include guard.	7 // Multiply-included message file, hence no include guard.

8	8

9 #include "content/public/common/webkit_param_traits.h"	9 #include "content/public/common/webkit_param_traits.h"

10 #include "ipc/ipc_channel_handle.h"	10 #include "ipc/ipc_channel_handle.h"

11 #include "ipc/ipc_message_macros.h"	11 #include "ipc/ipc_message_macros.h"

12	12

13 #define IPC_MESSAGE_START JavaBridgeMsgStart	13 #define IPC_MESSAGE_START JavaBridgeMsgStart

14	14

15 // Messages for handling Java objects injected into JavaScript -----------------	15 // Messages for handling Java objects injected into JavaScript -----------------

16	16

17 // Sent from browser to renderer to initialize the Java Bridge.	17 // Sent from browser to renderer to initialize the Java Bridge.

18 IPC_MESSAGE_ROUTED1(JavaBridgeMsg_Init,	18 IPC_MESSAGE_ROUTED0(JavaBridgeMsg_Init)

19 IPC::ChannelHandle) /* channel handle */	19

	20 // Sent from renderer to browser to get the channel handle for NP channel.

	21 IPC_SYNC_MESSAGE_ROUTED0_1(JavaBridgeMsg_GetChannelHandle,
	jam 2011/12/07 22:07:03 nit: renderer-> browser messages should have Host nit: renderer-> browser messages should have Host in them, i.e. JavaBridgeHostMsg_..., and it should be listed at the bottom of the file (see other files for example) Steve Block 2011/12/08 11:17:56 Done. Show quoted text On 2011/12/07 22:07:03, John Abd-El-Malek wrote: > nit: renderer-> browser messages should have Host in them, i.e. > JavaBridgeHostMsg_..., and it should be listed at the bottom of the file (see > other files for example) Done.
	22 IPC::ChannelHandle) /* channel handle */

20	23

21 // Sent from browser to renderer to add a Java object with the given name.	24 // Sent from browser to renderer to add a Java object with the given name.

22 IPC_MESSAGE_ROUTED2(JavaBridgeMsg_AddNamedObject,	25 IPC_MESSAGE_ROUTED2(JavaBridgeMsg_AddNamedObject,

23 string16 /* name */,	26 string16 /* name */,

24 NPVariant_Param) /* object */	27 NPVariant_Param) /* object */

25	28

26 // Sent from browser to renderer to remove a Java object with the given name.	29 // Sent from browser to renderer to remove a Java object with the given name.

27 IPC_MESSAGE_ROUTED1(JavaBridgeMsg_RemoveNamedObject,	30 IPC_MESSAGE_ROUTED1(JavaBridgeMsg_RemoveNamedObject,

28 string16 /* name */)	31 string16 /* name */)

OLD	NEW