Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 8834012: Quit MessageLoop in ui_test_utils::DOMOperationObserver when the RenderView goes away. (Closed)

Created:
9 years ago by Bernhard Bauer
Modified:
9 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Quit MessageLoop in ui_test_utils::DOMOperationObserver when the RenderView goes away. This should turn some timeouts caused by a renderer crash into immediate failures. BUG=106541 TEST=less timeouts Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113501

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/test/base/ui_test_utils.cc View 1 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review.
9 years ago (2011-12-07 18:20:43 UTC) #1
Paweł Hajdan Jr.
LGTM, thank you!
9 years ago (2011-12-07 19:58:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/8834012/2001
9 years ago (2011-12-07 21:58:43 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-07 23:18:07 UTC) #4
Change committed as 113501

Powered by Google App Engine
This is Rietveld 408576698