Hide default context menu for platform apps.

chrome/browser/renderer_host/chrome_render_view_host_observer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_render_view_host_observer.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/dom_operation_notification_details.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/site_instance.h"
+#include "content/common/view_messages.h"
 #include "content/public/browser/notification_service.h"
 
 ChromeRenderViewHostObserver::ChromeRenderViewHostObserver(
     RenderViewHost* render_view_host, chrome_browser_net::Predictor* predictor)
     : content::RenderViewHostObserver(render_view_host),
       predictor_(predictor) {
   SiteInstance* site_instance = render_view_host->site_instance();
   profile_ = Profile::FromBrowserContext(
       site_instance->browsing_instance()->browser_context());
 
@@ skipping 25 matching lines @@
 bool ChromeRenderViewHostObserver::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ChromeRenderViewHostObserver, message)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DomOperationResponse,
                         OnDomOperationResponse)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_FocusedEditableNodeTouched,
                         OnFocusedEditableNodeTouched)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
+
+  if (message.type() == ViewHostMsg_ContextMenu::ID) {

[Mihai Parparita -not on Chrome, 2011/12/08 03:34:52]

Blocking this at the IPC level doesn't seem quite right. I think there are two
ways we can approach context menus in platform apps:

1. Remove context menu support entirely, since it's up to apps to decide how
they want to handle right-clicks. In that case, we would ideally want to prevent
the IPC being sent in the first place. This might require making WebKit changes
(perhaps in
https://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/W...
to allow the ContextMenuClient (of which Chrome has an implementation) to say
that that context menus shouldn't be shown at all).

2. Allow platform apps to customize the content of context menus (they're not
shown by default, but they can request items to be shown in it). In that case
we'd want to modify the behavior of RenderViewContextMenu::InitMenu
(https://www.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/tab_contents...),
so that for platform apps none of the other context menu items are added, but
the ones specified by the app are added.

+    const Extension* extension = GetExtension();
+    if (extension && extension->is_platform_app())
+      handled = true;
+  }
+
   return handled;
 }
 
 void ChromeRenderViewHostObserver::InitRenderViewHostForExtensions() {
   const Extension* extension = GetExtension();
   if (!extension)
     return;
 
   ExtensionProcessManager* process_manager =
       profile_->GetExtensionProcessManager();
@@ skipping 94 matching lines @@
       content::Source<RenderViewHost>(render_view_host()),
       content::Details<DomOperationNotificationDetails>(&details));
 }
 
 void ChromeRenderViewHostObserver::OnFocusedEditableNodeTouched() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED,
       content::Source<RenderViewHost>(render_view_host()),
       content::NotificationService::NoDetails());
 }