Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 8834005: Remove write barriers for cells on x64, ARM and MIPS. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2569 matching lines...) Expand 10 before | Expand all | Expand 10 after
2580 // to update the property details in the property dictionary of the 2580 // to update the property details in the property dictionary of the
2581 // global object. We bail out to the runtime system to do that. 2581 // global object. We bail out to the runtime system to do that.
2582 __ mov(r4, Operand(cell)); 2582 __ mov(r4, Operand(cell));
2583 __ LoadRoot(r5, Heap::kTheHoleValueRootIndex); 2583 __ LoadRoot(r5, Heap::kTheHoleValueRootIndex);
2584 __ ldr(r6, FieldMemOperand(r4, JSGlobalPropertyCell::kValueOffset)); 2584 __ ldr(r6, FieldMemOperand(r4, JSGlobalPropertyCell::kValueOffset));
2585 __ cmp(r5, r6); 2585 __ cmp(r5, r6);
2586 __ b(eq, &miss); 2586 __ b(eq, &miss);
2587 2587
2588 // Store the value in the cell. 2588 // Store the value in the cell.
2589 __ str(r0, FieldMemOperand(r4, JSGlobalPropertyCell::kValueOffset)); 2589 __ str(r0, FieldMemOperand(r4, JSGlobalPropertyCell::kValueOffset));
2590 2590 // Cells are always rescanned, so no write barrier here.
2591 __ mov(r1, r0);
2592 __ RecordWriteField(r4,
2593 JSGlobalPropertyCell::kValueOffset,
2594 r1,
2595 r2,
2596 kLRHasNotBeenSaved,
2597 kDontSaveFPRegs,
2598 OMIT_REMEMBERED_SET);
2599 2591
2600 Counters* counters = masm()->isolate()->counters(); 2592 Counters* counters = masm()->isolate()->counters();
2601 __ IncrementCounter(counters->named_store_global_inline(), 1, r4, r3); 2593 __ IncrementCounter(counters->named_store_global_inline(), 1, r4, r3);
2602 __ Ret(); 2594 __ Ret();
2603 2595
2604 // Handle store cache miss. 2596 // Handle store cache miss.
2605 __ bind(&miss); 2597 __ bind(&miss);
2606 __ IncrementCounter(counters->named_store_global_inline_miss(), 1, r4, r3); 2598 __ IncrementCounter(counters->named_store_global_inline_miss(), 1, r4, r3);
2607 Handle<Code> ic = masm()->isolate()->builtins()->StoreIC_Miss(); 2599 Handle<Code> ic = masm()->isolate()->builtins()->StoreIC_Miss();
2608 __ Jump(ic, RelocInfo::CODE_TARGET); 2600 __ Jump(ic, RelocInfo::CODE_TARGET);
(...skipping 1625 matching lines...) Expand 10 before | Expand all | Expand 10 after
4234 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss(); 4226 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss();
4235 __ Jump(ic_miss, RelocInfo::CODE_TARGET); 4227 __ Jump(ic_miss, RelocInfo::CODE_TARGET);
4236 } 4228 }
4237 4229
4238 4230
4239 #undef __ 4231 #undef __
4240 4232
4241 } } // namespace v8::internal 4233 } } // namespace v8::internal
4242 4234
4243 #endif // V8_TARGET_ARCH_ARM 4235 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698