Issue 8833012: Fix the issue of ShellAcceleratorFilter sending accelerators twice for character keys.

Issue 8833012: Fix the issue of ShellAcceleratorFilter sending accelerators twice for character keys. (Closed)

Created:
9 years ago by mazda

Modified:
9 years ago

Reviewers:
Daniel Erat, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the issue of ShellAcceleratorFilter sending accelerators twice for character keys. I also added an unittest entry that checks the accelerator is processed only once. This test has failed before. This CL depends on http://codereview.chromium.org/8834014/ BUG=106702 TEST=Ran aura_shell_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114029

Patch Set 1 #

Patch Set 2 : Add an unittest entry #

Total comments: 4

Patch Set 3 : Address comments #

Patch Set 4 : Move the initialization of RootWindow into ProcessOnce #

Patch Set 5 : Delete an unused include #

Patch Set 6 : Rebase #

Patch Set 7 : Fix Win test failure #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -33 lines)			Patch
	M	ui/aura_shell/shell_accelerator_controller_unittest.cc	View	1 2 3 4 5 6	7 chunks	+69 lines, -28 lines	0 comments	Download
	M	ui/aura_shell/shell_accelerator_filter.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM with a few nits http://codereview.chromium.org/8833012/diff/1002/ui/aura_shell/shell_accelerator_controller_unittest.cc File ui/aura_shell/shell_accelerator_controller_unittest.cc (right): http://codereview.chromium.org/8833012/diff/1002/ui/aura_shell/shell_accelerator_controller_unittest.cc#newcode29 ui/aura_shell/shell_accelerator_controller_unittest.cc:29: bool accelerator_pressed() const { ...

9 years ago (2011-12-07 16:58:07 UTC) #2

mazda

http://codereview.chromium.org/8833012/diff/1002/ui/aura_shell/shell_accelerator_controller_unittest.cc File ui/aura_shell/shell_accelerator_controller_unittest.cc (right): http://codereview.chromium.org/8833012/diff/1002/ui/aura_shell/shell_accelerator_controller_unittest.cc#newcode29 ui/aura_shell/shell_accelerator_controller_unittest.cc:29: bool accelerator_pressed() const { On 2011/12/07 16:58:07, Daniel Erat ...

9 years ago (2011-12-08 05:39:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8833012/18001

9 years ago (2011-12-12 16:06:02 UTC) #6

Change committed as 114029

Expand Messages | Collapse Messages