Issue 8833009: Count of user dismissals of notification promo.

Issue 8833009: Count of user dismissals of notification promo. (Closed)

Created:
9 years ago by achuithb

Modified:
9 years ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Count user dismissals of notification promo. Also move NTPPromoShown to notification_promo.cc BUG=106743 TEST=NONE. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113468

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/web_resource/notification_promo.cc	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Miranda Callahan

On 2011/12/07 10:31:07, achuith.bhandarkar wrote: > Please review, Miranda. Thanks! LGTM!

9 years ago (2011-12-07 15:01:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8833009/2001

9 years ago (2011-12-07 18:48:47 UTC) #3

achuithb

On 2011/12/07 18:48:47, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

9 years ago (2011-12-07 18:50:19 UTC) #4

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

9 years ago (2011-12-07 20:18:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8833009/2001

9 years ago (2011-12-07 20:23:24 UTC) #6

Change committed as 113468