Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 8833007: Fix a bug with register use in optimized Math.round. (Closed)

Created:
9 years ago by fschneider
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug with register use in optimized Math.round. We're not allowed to modify the input register and have to use a temporary instead, otherwise the result of expressions containing Math.round can be wrong. BUG=106351 TEST=test/mjsunit/compiler/regress-106351.js Committed: http://code.google.com/p/v8/source/detail?r=10190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/regress-106351.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years ago (2011-12-07 09:37:04 UTC) #1
Kevin Millikin (Chromium)
9 years ago (2011-12-07 10:10:04 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698