Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: ui/views/bubble/bubble_delegate_unittest.cc

Issue 8833004: Remove BubbleDelegateView ctor color arg, add simple setter/getter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pass set_color SkColor arg by value. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/bubble/bubble_delegate.cc ('k') | ui/views/examples/bubble_example.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_delegate_unittest.cc
diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc
index 7cfda58dca96e258dc97a7892859dc4b5ca177a4..9fac58bcbe094a59eb4c449adf7a03945777251a 100644
--- a/ui/views/bubble/bubble_delegate_unittest.cc
+++ b/ui/views/bubble/bubble_delegate_unittest.cc
@@ -12,8 +12,9 @@ namespace views {
typedef ViewsTestBase BubbleDelegateTest;
TEST_F(BubbleDelegateTest, CreateDelegate) {
- BubbleDelegateView* bubble_delegate = new BubbleDelegateView(
- NULL, BubbleBorder::NONE, SK_ColorGREEN);
+ BubbleDelegateView* bubble_delegate =
+ new BubbleDelegateView(NULL, BubbleBorder::NONE);
+ bubble_delegate->set_color(SK_ColorGREEN);
Widget* bubble_widget(
BubbleDelegateView::CreateBubble(bubble_delegate));
EXPECT_EQ(bubble_delegate, bubble_widget->widget_delegate());
@@ -22,7 +23,7 @@ TEST_F(BubbleDelegateTest, CreateDelegate) {
BubbleBorder* border =
bubble_delegate->GetBubbleFrameView()->bubble_border();
EXPECT_EQ(bubble_delegate->GetArrowLocation(), border->arrow_location());
- EXPECT_EQ(bubble_delegate->GetColor(), border->background_color());
+ EXPECT_EQ(bubble_delegate->color(), border->background_color());
bubble_widget->CloseNow();
RunPendingMessages();
« no previous file with comments | « ui/views/bubble/bubble_delegate.cc ('k') | ui/views/examples/bubble_example.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698