Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Side by Side Diff: src/factory.cc

Issue 8833: Change the order of two assignments, to make sure that the script type... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 return info; 131 return info;
132 } 132 }
133 133
134 134
135 Handle<Script> Factory::NewScript(Handle<String> source) { 135 Handle<Script> Factory::NewScript(Handle<String> source) {
136 Handle<Script> script = Handle<Script>::cast(NewStruct(SCRIPT_TYPE)); 136 Handle<Script> script = Handle<Script>::cast(NewStruct(SCRIPT_TYPE));
137 script->set_source(*source); 137 script->set_source(*source);
138 script->set_name(Heap::undefined_value()); 138 script->set_name(Heap::undefined_value());
139 script->set_line_offset(Smi::FromInt(0)); 139 script->set_line_offset(Smi::FromInt(0));
140 script->set_column_offset(Smi::FromInt(0)); 140 script->set_column_offset(Smi::FromInt(0));
141 script->set_type(Smi::FromInt(SCRIPT_TYPE_NORMAL));
141 script->set_wrapper(*Factory::NewProxy(0, TENURED)); 142 script->set_wrapper(*Factory::NewProxy(0, TENURED));
142 script->set_type(Smi::FromInt(SCRIPT_TYPE_NORMAL));
143 return script; 143 return script;
144 } 144 }
145 145
146 146
147 Handle<Proxy> Factory::NewProxy(Address addr, PretenureFlag pretenure) { 147 Handle<Proxy> Factory::NewProxy(Address addr, PretenureFlag pretenure) {
148 CALL_HEAP_FUNCTION(Heap::AllocateProxy(addr, pretenure), Proxy); 148 CALL_HEAP_FUNCTION(Heap::AllocateProxy(addr, pretenure), Proxy);
149 } 149 }
150 150
151 151
152 Handle<Proxy> Factory::NewProxy(const AccessorDescriptor* desc) { 152 Handle<Proxy> Factory::NewProxy(const AccessorDescriptor* desc) {
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
832 Execution::ConfigureInstance(instance, 832 Execution::ConfigureInstance(instance,
833 instance_template, 833 instance_template,
834 pending_exception); 834 pending_exception);
835 } else { 835 } else {
836 *pending_exception = false; 836 *pending_exception = false;
837 } 837 }
838 } 838 }
839 839
840 840
841 } } // namespace v8::internal 841 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698