Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/testing/dart/multitest.dart

Issue 8832008: Make test scripts work on Windows again. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/multitest.dart
diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart
index 79866789f43723b7bfb6b1b9362235f2842ca06b..9a3045b5645fb71ab7802c16aaf307dad76f1717 100644
--- a/tools/testing/dart/multitest.dart
+++ b/tools/testing/dart/multitest.dart
@@ -197,15 +197,15 @@ WriteMultitestToFileAndQueueIt(Map<String, String> tests,
}
String CreateMultitestDirectory(String buildDir, String testDir) {
- final String generatedTestDirectory = 'generated_tests/';
+ final String generatedTestDirectory = 'generated_tests';
Directory parentDir = new Directory(buildDir + generatedTestDirectory);
if (!parentDir.existsSync()) {
parentDir.createSync();
}
- var split = testDir.split(new Platform().pathSeparator());
+ var split = testDir.split('/');
var lastComponent = split.removeLast();
Expect.isTrue(lastComponent == 'src');
- String path = parentDir.path + split.last();
+ String path = '${parentDir.path}/${split.last()}';
Directory dir = new Directory(path);
if (!dir.existsSync()) {
dir.createSync();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698