Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: tools/testing/dart/multitest.dart

Issue 8832008: Make test scripts work on Windows again. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/multitest.dart
diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart
index 79866789f43723b7bfb6b1b9362235f2842ca06b..0fb91c77bd524a1ffe55c1adccd812dc417c994e 100644
--- a/tools/testing/dart/multitest.dart
+++ b/tools/testing/dart/multitest.dart
@@ -197,12 +197,12 @@ WriteMultitestToFileAndQueueIt(Map<String, String> tests,
}
String CreateMultitestDirectory(String buildDir, String testDir) {
- final String generatedTestDirectory = 'generated_tests/';
+ final String generatedTestDirectory = 'generated_tests';
Directory parentDir = new Directory(buildDir + generatedTestDirectory);
if (!parentDir.existsSync()) {
parentDir.createSync();
}
- var split = testDir.split(new Platform().pathSeparator());
+ var split = testDir.split('/');
var lastComponent = split.removeLast();
Expect.isTrue(lastComponent == 'src');
String path = parentDir.path + split.last();
Bill Hesse 2011/12/07 14:36:54 We may need to put a / between the two components
Mads Ager (google) 2011/12/07 14:40:46 We do need that. Thanks!
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698