Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: net/http/http_cache.h

Issue 8832006: Reverts a commit that caused ASAN failures, and 2 dependent commits. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/disk_cache_based_ssl_host_info.cc ('k') | net/http/http_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache.h
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index 176d9ffe7cb8594d214ae93245782c8eb01f0c64..526da587b173002035341e0e0ab505991b9f68b4 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -157,8 +157,7 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
// a network error code, and it could be ERR_IO_PENDING, in which case the
// |callback| will be notified when the operation completes. The pointer that
// receives the |backend| must remain valid until the operation completes.
- int GetBackend(disk_cache::Backend** backend,
- const CompletionCallback& callback);
+ int GetBackend(disk_cache::Backend** backend, OldCompletionCallback* callback);
// Returns the current backend (can be NULL).
disk_cache::Backend* GetCurrentBackend() const;
@@ -191,7 +190,7 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
// referred to by |url| and |http_method|.
void OnExternalCacheHit(const GURL& url, const std::string& http_method);
- // HttpTransactionFactory implementation.
+ // HttpTransactionFactory implementation:
virtual int CreateTransaction(scoped_ptr<HttpTransaction>* trans) OVERRIDE;
virtual HttpCache* GetCache() OVERRIDE;
virtual HttpNetworkSession* GetSession() OVERRIDE;
@@ -244,7 +243,7 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
// Creates the |backend| object and notifies the |callback| when the operation
// completes. Returns an error code.
int CreateBackend(disk_cache::Backend** backend,
- const CompletionCallback& callback);
+ OldCompletionCallback* callback);
// Makes sure that the backend creation is complete before allowing the
// provided transaction to use the object. Returns an error code. |trans|
« no previous file with comments | « net/http/disk_cache_based_ssl_host_info.cc ('k') | net/http/http_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698