Reverts a commit that caused ASAN failures, and 2 dependent commits.

Reverts a commit that caused ASAN failures, and 2 dependent commits.

The primary commit was 113249, the dependents were 113261, 113263.

This is a speculative revert, r113249 is by far the likeliest culprit in the blamelist of build http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/builds/2325 which is where we started seeing the ASAN failures in question, will un-revert if it does not fix the problem.

TBR=jhawkins@chromium.org
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113387

[Jói, 2011-12-07 12:41:39]

Hi James,

I spent a good 15 minutes or so trying to understand the change well enough to
spot the real problem, but I can't so I have to try a revert, since this has
been flaking out Mac tests as well as the ASAN bot since some time yesterday.

I will TBR this through the CQ to see if it greens up the tree.

Cheers,
Jói

[commit-bot: I haz the power, 2011-12-07 12:42:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/8832006/1

[commit-bot: I haz the power, 2011-12-07 12:42:42]

Presubmit check for 8832006-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  net/disk_cache/in_flight_backend_io.h, line 174, 83 chars \
  net/http/http_cache.h, line 160, 81 chars \
  net/http/mock_http_cache.cc, line 284, 83 chars \
  net/http/mock_http_cache.cc, line 307, 82 chars

The old callback system is deprecated. If possible, use base::Bind and
base::Callback instead.
    net/http/mock_http_cache.cc:328

Presubmit checks took 2.3s to calculate.

[Jói, 2011-12-07 12:44:59]

That's because it's a straight revert.  Will do a good old-fashioned try.

On Wed, Dec 7, 2011 at 12:42 PM,  <commit-bot@chromium.org> wrote:
> Presubmit check for 8832006-1 failed and returned exit status 1.
>
> Running presubmit commit checks ...
>
> ** Presubmit Messages **
> --tbr was specified, skipping OWNERS check
>
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
>
> ** Presubmit Warnings **
> Found lines longer than 80 characters (first 5 shown).
>  net/disk_cache/in_flight_backend_io.h, line 174, 83 chars \
>  net/http/http_cache.h, line 160, 81 chars \
>  net/http/mock_http_cache.cc, line 284, 83 chars \
>  net/http/mock_http_cache.cc, line 307, 82 chars
>
> The old callback system is deprecated. If possible, use base::Bind and
> base::Callback instead.
>    net/http/mock_http_cache.cc:328
>
> Presubmit checks took 2.3s to calculate.
>
>
>
> http://codereview.chromium.org/8832006/

[Jói, 2011-12-07 12:47:30]

Here is a sample ASAN log for the problem this revert is trying to address:

Note: Google Test filter = FormStructureBrowserTest.DataDrivenHeuristics13
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FormStructureBrowserTest, where TypeParam =
[ RUN      ] FormStructureBrowserTest.DataDrivenHeuristics13
[3381:3381:1206/123529:2609376289:WARNING:zygote_host_linux.cc(149)]
Running without the SUID sandbox! See
http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for
more information on developing with the sandbox on.
[3381:3384:1206/123529:2609387171:ERROR:object_proxy.cc(239)] Failed
to call method: org.freedesktop.DBus.Error.ServiceUnknown: The name
org.freedesktop.NetworkManager was not provided by any .service files
=================================================================
==3381== ERROR: AddressSanitizer heap-use-after-free on address
0x7fdbf66e3218 at pc 0x2a17868 bp 0x7fdbfe67d450 sp 0x7fdbfe67d428
WRITE of size 8 at 0x7fdbf66e3218 thread T8
    #0 0x2a17868 in
disk_cache::BackendImpl::SyncOpenEntry(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&,
disk_cache::Entry**) ???:0
    #1 0x2a77f4f in disk_cache::BackendIO::ExecuteBackendOperation() ???:0
    #2 0x2639e0f in MessageLoop::RunTask(base::PendingTask const&) ???:0
    #3 0x263a6a6 in
MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) ???:0
    #4 0x263b9a1 in MessageLoop::DoWork() ???:0
    #5 0x25cf96d in
base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ???:0
    #6 0x2638a0e in MessageLoop::RunInternal() ???:0
    #7 0x2636abf in MessageLoop::Run() ???:0
    #8 0x26a7564 in base::Thread::ThreadMain() ???:0
    #9 0x26a53dc in base::(anonymous namespace)::ThreadFunc(void*)
base/threading/platform_thread_posix.cc:0
    #10 0x7e9209d in __asan::AsanThread::ThreadStart()
/usr/local/google/asan/address-sanitizer/asan/asan_thread.cc:77
    #11 0x7e87258 in __asan::asan_thread_start(void*) _asan_rtl_
    #12 0x7fdc115499ca in start_thread
/build/buildd/eglibc-2.11.1/nptl/pthread_create.c:300
    #13 0x7fdc0c71070d in ??
/build/buildd/eglibc-2.11.1/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:114
0x7fdbf66e3218 is located 408 bytes inside of 456-byte region
[0x7fdbf66e3080,0x7fdbf66e3248)
freed by thread T9 here:
    #0 0x7e88479 in operator delete(void*) _asan_rtl_
    #1 0x29417a8 in net::SSLConnectJob::~SSLConnectJob() ???:0
    #2 0x2941701 in net::SSLConnectJob::~SSLConnectJob() ???:0
    #3 0x2b36800 in
net::internal::ClientSocketPoolBaseHelper::RemoveConnectJob(net::ConnectJob*,
net::internal::ClientSocketPoolBaseHelper::Group*) ???:0
    #4 0x2b3a88b in
net::internal::ClientSocketPoolBaseHelper::OnConnectJobComplete(int,
net::ConnectJob*) ???:0
    #5 0x2915585 in net::ClientSocketHandle::OnIOComplete(int) ???:0
    #6 0x2b3c938 in
net::internal::ClientSocketPoolBaseHelper::InvokeUserCallback(net::ClientSocketHandle*)
???:0
    #7 0x26a4909 in base::subtle::TaskClosureAdapter::Run() ???:0
    #8 0x2639e0f in MessageLoop::RunTask(base::PendingTask const&) ???:0
    #9 0x263a6a6 in
MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) ???:0
    #10 0x263b9a1 in MessageLoop::DoWork() ???:0
    #11 0x25cf96d in
base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ???:0
    #12 0x2638a0e in MessageLoop::RunInternal() ???:0
    #13 0x2636abf in MessageLoop::Run() ???:0
    #14 0x26a7564 in base::Thread::ThreadMain() ???:0
    #15 0x26a53dc in base::(anonymous namespace)::ThreadFunc(void*)
base/threading/platform_thread_posix.cc:0
    #16 0x7e9209d in __asan::AsanThread::ThreadStart()
/usr/local/google/asan/address-sanitizer/asan/asan_thread.cc:77
    #17 0x7e87258 in __asan::asan_thread_start(void*) _asan_rtl_
    #18 0x7fdc115499ca in start_thread
/build/buildd/eglibc-2.11.1/nptl/pthread_create.c:300
previously allocated by thread T9 here:
    #0 0x7e880f3 in operator new(unsigned long) _asan_rtl_
    #1 0x285bace in
net::HttpCache::SSLHostInfoFactoryAdaptor::GetForHost(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&, net::SSLConfig
const&) ???:0
    #2 0x29427b5 in net::SSLConnectJob::DoTransportConnect() ???:0
    #3 0x2941f02 in net::SSLConnectJob::DoLoop(int) ???:0
    #4 0x29455ad in net::SSLConnectJob::ConnectInternal() ???:0
    #5 0x2b2ebf9 in net::ConnectJob::Connect() ???:0
    #6 0x2b32e1b in
net::internal::ClientSocketPoolBaseHelper::RequestSocketInternal(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&,
net::internal::ClientSocketPoolBaseHelper::Request const*) ???:0
    #7 0x2b31c82 in
net::internal::ClientSocketPoolBaseHelper::RequestSocket(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&,
net::internal::ClientSocketPoolBaseHelper::Request const*) ???:0
    #8 0x291c496 in int
net::ClientSocketHandle::Init<net::SSLSocketParams,
net::SSLClientSocketPool>(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&,
scoped_refptr<net::SSLSocketParams> const&, net::RequestPriority,
CallbackRunner<Tuple1<int> >*, net::SSLClientSocketPool*,
net::BoundNetLog const&) ???:0
    #9 0x291b013 in net::(anonymous
namespace)::InitSocketPoolHelper(GURL const&, net::HttpRequestHeaders
const&, int, net::RequestPriority, net::HttpNetworkSession*,
net::ProxyInfo const&, bool, bool, net::SSLConfig const&,
net::SSLConfig const&, bool, net::BoundNetLog const&, int,
net::ClientSocketHandle*, CallbackRunner<Tuple1<int> >*)
net/socket/client_socket_pool_manager.cc:0
    #10 0x2919b28 in net::InitSocketHandleForHttpRequest(GURL const&,
net::HttpRequestHeaders const&, int, net::RequestPriority,
net::HttpNetworkSession*, net::ProxyInfo const&, bool, bool,
net::SSLConfig const&, net::SSLConfig const&, net::BoundNetLog const&,
net::ClientSocketHandle*, CallbackRunner<Tuple1<int> >*) ???:0
    #11 0x28c1f8e in net::HttpStreamFactoryImpl::Job::DoInitConnection() ???:0
    #12 0x28c0182 in net::HttpStreamFactoryImpl::Job::DoLoop(int) ???:0
    #13 0x28ba87b in net::HttpStreamFactoryImpl::Job::RunLoop(int) ???:0
    #14 0x28b9b7e in net::HttpStreamFactoryImpl::Job::StartInternal() ???:0
    #15 0x28b9598 in
net::HttpStreamFactoryImpl::Job::Start(net::HttpStreamFactoryImpl::Request*)
???:0
    #16 0x28ae1eb in
net::HttpStreamFactoryImpl::RequestStream(net::HttpRequestInfo const&,
net::SSLConfig const&, net::SSLConfig const&,
net::HttpStreamRequest::Delegate*, net::BoundNetLog const&) ???:0
    #17 0x287e882 in net::HttpNetworkTransaction::DoCreateStream() ???:0
    #18 0x287877e in net::HttpNetworkTransaction::DoLoop(int) ???:0
    #19 0x28781e4 in
net::HttpNetworkTransaction::Start(net::HttpRequestInfo const*,
CallbackRunner<Tuple1<int> >*, net::BoundNetLog const&) ???:0
    #20 0x28653c6 in net::HttpCache::Transaction::DoSendRequest() ???:0
    #21 0x285ef2e in net::HttpCache::Transaction::DoLoop(int) ???:0
    #22 0x2860a07 in
net::HttpCache::Transaction::Start(net::HttpRequestInfo const*,
CallbackRunner<Tuple1<int> >*, net::BoundNetLog const&) ???:0
    #23 0x2b6b4e9 in net::URLRequestHttpJob::StartTransactionInternal() ???:0
Thread T8 created by T0 here:
    #0 0x7e88813 in pthread_create _asan_rtl_
    #1 0x26a4fc9 in base::(anonymous namespace)::CreateThread(unsigned
long, bool, base::PlatformThread::Delegate*, unsigned long*)
base/threading/platform_thread_posix.cc:0
    #2 0x26a4eca in base::PlatformThread::Create(unsigned long,
base::PlatformThread::Delegate*, unsigned long*) ???:0
    #3 0x26a6d55 in
base::Thread::StartWithOptions(base::Thread::Options const&) ???:0
    #4 0x6863e5b in
content::BrowserMainLoop::RunMainMessageLoopParts(bool*) ???:0
    #5 0x6acbf62 in BrowserMain(content::MainFunctionParams const&) ???:0
    #6 0x72ab86b in BrowserTestBase::SetUp() ???:0
    #7 0x2561e42 in InProcessBrowserTest::SetUp() ???:0
    #8 0x2d56f14 in testing::Test::Run() ???:0
    #9 0x2d58eaa in testing::TestInfo::Run() ???:0
    #10 0x2d5a4c8 in testing::TestCase::Run() ???:0
    #11 0x2d672bf in testing::internal::UnitTestImpl::RunAllTests() ???:0
    #12 0x2d6697f in bool
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) ???:0
    #13 0x2d6677b in testing::UnitTest::Run() ???:0
    #14 0x26f43c8 in base::TestSuite::Run() ???:0
    #15 0xda6ec9 in ChromeTestLauncherDelegate::RunTestSuite(int, char**) ???:0
    #16 0xeac27e in
test_launcher::LaunchTests(test_launcher::TestLauncherDelegate*, int,
char**) ???:0
    #17 0xda6ba6 in main ???:0
    #18 0x7fdc0c648c4d in __libc_start_main
/build/buildd/eglibc-2.11.1/csu/libc-start.c:258
Thread T9 created by T0 here:
    #0 0x7e88813 in pthread_create _asan_rtl_
    #1 0x26a4fc9 in base::(anonymous namespace)::CreateThread(unsigned
long, bool, base::PlatformThread::Delegate*, unsigned long*)
base/threading/platform_thread_posix.cc:0
    #2 0x26a4eca in base::PlatformThread::Create(unsigned long,
base::PlatformThread::Delegate*, unsigned long*) ???:0
    #3 0x26a6d55 in
base::Thread::StartWithOptions(base::Thread::Options const&) ???:0
    #4 0x6863e5b in
content::BrowserMainLoop::RunMainMessageLoopParts(bool*) ???:0
    #5 0x6acbf62 in BrowserMain(content::MainFunctionParams const&) ???:0
    #6 0x72ab86b in BrowserTestBase::SetUp() ???:0
    #7 0x2561e42 in InProcessBrowserTest::SetUp() ???:0
    #8 0x2d56f14 in testing::Test::Run() ???:0
    #9 0x2d58eaa in testing::TestInfo::Run() ???:0
    #10 0x2d5a4c8 in testing::TestCase::Run() ???:0
    #11 0x2d672bf in testing::internal::UnitTestImpl::RunAllTests() ???:0
    #12 0x2d6697f in bool
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool>(testing::internal::UnitTestImpl*, bool
(testing::internal::UnitTestImpl::*)(), char const*) ???:0
    #13 0x2d6677b in testing::UnitTest::Run() ???:0
    #14 0x26f43c8 in base::TestSuite::Run() ???:0
    #15 0xda6ec9 in ChromeTestLauncherDelegate::RunTestSuite(int, char**) ???:0
    #16 0xeac27e in
test_launcher::LaunchTests(test_launcher::TestLauncherDelegate*, int,
char**) ???:0
    #17 0xda6ba6 in main ???:0
    #18 0x7fdc0c648c4d in __libc_start_main
/build/buildd/eglibc-2.11.1/csu/libc-start.c:258
==3381== ABORTING
Shadow byte and word:
  0x1ffb7ecdc643: fd
  0x1ffb7ecdc640: fd fd fd fd fd fd fd fd
More shadow bytes:
  0x1ffb7ecdc620: fd fd fd fd fd fd fd fd
  0x1ffb7ecdc628: fd fd fd fd fd fd fd fd
  0x1ffb7ecdc630: fd fd fd fd fd fd fd fd
  0x1ffb7ecdc638: fd fd fd fd fd fd fd fd
=>0x1ffb7ecdc640: fd fd fd fd fd fd fd fd
  0x1ffb7ecdc648: fd fd fd fd fd fd fd fd
  0x1ffb7ecdc650: fa fa fa fa fa fa fa fa
  0x1ffb7ecdc658: fa fa fa fa fa fa fa fa
  0x1ffb7ecdc660: fa fa fa fa fa fa fa fa

2011/12/7 Jói Sigurðsson <joi@chromium.org>:
> That's because it's a straight revert.  Will do a good old-fashioned try.
>
> On Wed, Dec 7, 2011 at 12:42 PM,  <commit-bot@chromium.org> wrote:
>> Presubmit check for 8832006-1 failed and returned exit status 1.
>>
>> Running presubmit commit checks ...
>>
>> ** Presubmit Messages **
>> --tbr was specified, skipping OWNERS check
>>
>> If this change requires manual test instructions to QA team, add
>> TEST=[instructions].
>>
>> ** Presubmit Warnings **
>> Found lines longer than 80 characters (first 5 shown).
>>  net/disk_cache/in_flight_backend_io.h, line 174, 83 chars \
>>  net/http/http_cache.h, line 160, 81 chars \
>>  net/http/mock_http_cache.cc, line 284, 83 chars \
>>  net/http/mock_http_cache.cc, line 307, 82 chars
>>
>> The old callback system is deprecated. If possible, use base::Bind and
>> base::Callback instead.
>>    net/http/mock_http_cache.cc:328
>>
>> Presubmit checks took 2.3s to calculate.
>>
>>
>>
>> http://codereview.chromium.org/8832006/

[Jói, 2011-12-07 16:04:04]

The revert cleared up the redness on the ASAN bot, first green build
in a long time is
http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/b...
which has the revert on the blamelist.

Cheers,
Jói


2011/12/7 Jói Sigurðsson <joi@chromium.org>:
> Here is a sample ASAN log for the problem this revert is trying to address:
>
> Note: Google Test filter = FormStructureBrowserTest.DataDrivenHeuristics13
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FormStructureBrowserTest, where TypeParam =
> [ RUN      ] FormStructureBrowserTest.DataDrivenHeuristics13
> [3381:3381:1206/123529:2609376289:WARNING:zygote_host_linux.cc(149)]
> Running without the SUID sandbox! See
> http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for
> more information on developing with the sandbox on.
> [3381:3384:1206/123529:2609387171:ERROR:object_proxy.cc(239)] Failed
> to call method: org.freedesktop.DBus.Error.ServiceUnknown: The name
> org.freedesktop.NetworkManager was not provided by any .service files
> =================================================================
> ==3381== ERROR: AddressSanitizer heap-use-after-free on address
> 0x7fdbf66e3218 at pc 0x2a17868 bp 0x7fdbfe67d450 sp 0x7fdbfe67d428
> WRITE of size 8 at 0x7fdbf66e3218 thread T8
>    #0 0x2a17868 in
> disk_cache::BackendImpl::SyncOpenEntry(std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > const&,
> disk_cache::Entry**) ???:0
>    #1 0x2a77f4f in disk_cache::BackendIO::ExecuteBackendOperation() ???:0
>    #2 0x2639e0f in MessageLoop::RunTask(base::PendingTask const&) ???:0
>    #3 0x263a6a6 in
> MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) ???:0
>    #4 0x263b9a1 in MessageLoop::DoWork() ???:0
>    #5 0x25cf96d in
> base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ???:0
>    #6 0x2638a0e in MessageLoop::RunInternal() ???:0
>    #7 0x2636abf in MessageLoop::Run() ???:0
>    #8 0x26a7564 in base::Thread::ThreadMain() ???:0
>    #9 0x26a53dc in base::(anonymous namespace)::ThreadFunc(void*)
> base/threading/platform_thread_posix.cc:0
>    #10 0x7e9209d in __asan::AsanThread::ThreadStart()
> /usr/local/google/asan/address-sanitizer/asan/asan_thread.cc:77
>    #11 0x7e87258 in __asan::asan_thread_start(void*) _asan_rtl_
>    #12 0x7fdc115499ca in start_thread
> /build/buildd/eglibc-2.11.1/nptl/pthread_create.c:300
>    #13 0x7fdc0c71070d in ??
> /build/buildd/eglibc-2.11.1/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:114
> 0x7fdbf66e3218 is located 408 bytes inside of 456-byte region
> [0x7fdbf66e3080,0x7fdbf66e3248)
> freed by thread T9 here:
>    #0 0x7e88479 in operator delete(void*) _asan_rtl_
>    #1 0x29417a8 in net::SSLConnectJob::~SSLConnectJob() ???:0
>    #2 0x2941701 in net::SSLConnectJob::~SSLConnectJob() ???:0
>    #3 0x2b36800 in
> net::internal::ClientSocketPoolBaseHelper::RemoveConnectJob(net::ConnectJob*,
> net::internal::ClientSocketPoolBaseHelper::Group*) ???:0
>    #4 0x2b3a88b in
> net::internal::ClientSocketPoolBaseHelper::OnConnectJobComplete(int,
> net::ConnectJob*) ???:0
>    #5 0x2915585 in net::ClientSocketHandle::OnIOComplete(int) ???:0
>    #6 0x2b3c938 in
>
net::internal::ClientSocketPoolBaseHelper::InvokeUserCallback(net::ClientSocketHandle*)
> ???:0
>    #7 0x26a4909 in base::subtle::TaskClosureAdapter::Run() ???:0
>    #8 0x2639e0f in MessageLoop::RunTask(base::PendingTask const&) ???:0
>    #9 0x263a6a6 in
> MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) ???:0
>    #10 0x263b9a1 in MessageLoop::DoWork() ???:0
>    #11 0x25cf96d in
> base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ???:0
>    #12 0x2638a0e in MessageLoop::RunInternal() ???:0
>    #13 0x2636abf in MessageLoop::Run() ???:0
>    #14 0x26a7564 in base::Thread::ThreadMain() ???:0
>    #15 0x26a53dc in base::(anonymous namespace)::ThreadFunc(void*)
> base/threading/platform_thread_posix.cc:0
>    #16 0x7e9209d in __asan::AsanThread::ThreadStart()
> /usr/local/google/asan/address-sanitizer/asan/asan_thread.cc:77
>    #17 0x7e87258 in __asan::asan_thread_start(void*) _asan_rtl_
>    #18 0x7fdc115499ca in start_thread
> /build/buildd/eglibc-2.11.1/nptl/pthread_create.c:300
> previously allocated by thread T9 here:
>    #0 0x7e880f3 in operator new(unsigned long) _asan_rtl_
>    #1 0x285bace in
> net::HttpCache::SSLHostInfoFactoryAdaptor::GetForHost(std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > const&, net::SSLConfig
> const&) ???:0
>    #2 0x29427b5 in net::SSLConnectJob::DoTransportConnect() ???:0
>    #3 0x2941f02 in net::SSLConnectJob::DoLoop(int) ???:0
>    #4 0x29455ad in net::SSLConnectJob::ConnectInternal() ???:0
>    #5 0x2b2ebf9 in net::ConnectJob::Connect() ???:0
>    #6 0x2b32e1b in
>
net::internal::ClientSocketPoolBaseHelper::RequestSocketInternal(std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > const&,
> net::internal::ClientSocketPoolBaseHelper::Request const*) ???:0
>    #7 0x2b31c82 in
>
net::internal::ClientSocketPoolBaseHelper::RequestSocket(std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > const&,
> net::internal::ClientSocketPoolBaseHelper::Request const*) ???:0
>    #8 0x291c496 in int
> net::ClientSocketHandle::Init<net::SSLSocketParams,
> net::SSLClientSocketPool>(std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > const&,
> scoped_refptr<net::SSLSocketParams> const&, net::RequestPriority,
> CallbackRunner<Tuple1<int> >*, net::SSLClientSocketPool*,
> net::BoundNetLog const&) ???:0
>    #9 0x291b013 in net::(anonymous
> namespace)::InitSocketPoolHelper(GURL const&, net::HttpRequestHeaders
> const&, int, net::RequestPriority, net::HttpNetworkSession*,
> net::ProxyInfo const&, bool, bool, net::SSLConfig const&,
> net::SSLConfig const&, bool, net::BoundNetLog const&, int,
> net::ClientSocketHandle*, CallbackRunner<Tuple1<int> >*)
> net/socket/client_socket_pool_manager.cc:0
>    #10 0x2919b28 in net::InitSocketHandleForHttpRequest(GURL const&,
> net::HttpRequestHeaders const&, int, net::RequestPriority,
> net::HttpNetworkSession*, net::ProxyInfo const&, bool, bool,
> net::SSLConfig const&, net::SSLConfig const&, net::BoundNetLog const&,
> net::ClientSocketHandle*, CallbackRunner<Tuple1<int> >*) ???:0
>    #11 0x28c1f8e in net::HttpStreamFactoryImpl::Job::DoInitConnection() ???:0
>    #12 0x28c0182 in net::HttpStreamFactoryImpl::Job::DoLoop(int) ???:0
>    #13 0x28ba87b in net::HttpStreamFactoryImpl::Job::RunLoop(int) ???:0
>    #14 0x28b9b7e in net::HttpStreamFactoryImpl::Job::StartInternal() ???:0
>    #15 0x28b9598 in
> net::HttpStreamFactoryImpl::Job::Start(net::HttpStreamFactoryImpl::Request*)
> ???:0
>    #16 0x28ae1eb in
> net::HttpStreamFactoryImpl::RequestStream(net::HttpRequestInfo const&,
> net::SSLConfig const&, net::SSLConfig const&,
> net::HttpStreamRequest::Delegate*, net::BoundNetLog const&) ???:0
>    #17 0x287e882 in net::HttpNetworkTransaction::DoCreateStream() ???:0
>    #18 0x287877e in net::HttpNetworkTransaction::DoLoop(int) ???:0
>    #19 0x28781e4 in
> net::HttpNetworkTransaction::Start(net::HttpRequestInfo const*,
> CallbackRunner<Tuple1<int> >*, net::BoundNetLog const&) ???:0
>    #20 0x28653c6 in net::HttpCache::Transaction::DoSendRequest() ???:0
>    #21 0x285ef2e in net::HttpCache::Transaction::DoLoop(int) ???:0
>    #22 0x2860a07 in
> net::HttpCache::Transaction::Start(net::HttpRequestInfo const*,
> CallbackRunner<Tuple1<int> >*, net::BoundNetLog const&) ???:0
>    #23 0x2b6b4e9 in net::URLRequestHttpJob::StartTransactionInternal() ???:0
> Thread T8 created by T0 here:
>    #0 0x7e88813 in pthread_create _asan_rtl_
>    #1 0x26a4fc9 in base::(anonymous namespace)::CreateThread(unsigned
> long, bool, base::PlatformThread::Delegate*, unsigned long*)
> base/threading/platform_thread_posix.cc:0
>    #2 0x26a4eca in base::PlatformThread::Create(unsigned long,
> base::PlatformThread::Delegate*, unsigned long*) ???:0
>    #3 0x26a6d55 in
> base::Thread::StartWithOptions(base::Thread::Options const&) ???:0
>    #4 0x6863e5b in
> content::BrowserMainLoop::RunMainMessageLoopParts(bool*) ???:0
>    #5 0x6acbf62 in BrowserMain(content::MainFunctionParams const&) ???:0
>    #6 0x72ab86b in BrowserTestBase::SetUp() ???:0
>    #7 0x2561e42 in InProcessBrowserTest::SetUp() ???:0
>    #8 0x2d56f14 in testing::Test::Run() ???:0
>    #9 0x2d58eaa in testing::TestInfo::Run() ???:0
>    #10 0x2d5a4c8 in testing::TestCase::Run() ???:0
>    #11 0x2d672bf in testing::internal::UnitTestImpl::RunAllTests() ???:0
>    #12 0x2d6697f in bool
>
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) ???:0
>    #13 0x2d6677b in testing::UnitTest::Run() ???:0
>    #14 0x26f43c8 in base::TestSuite::Run() ???:0
>    #15 0xda6ec9 in ChromeTestLauncherDelegate::RunTestSuite(int, char**) ???:0
>    #16 0xeac27e in
> test_launcher::LaunchTests(test_launcher::TestLauncherDelegate*, int,
> char**) ???:0
>    #17 0xda6ba6 in main ???:0
>    #18 0x7fdc0c648c4d in __libc_start_main
> /build/buildd/eglibc-2.11.1/csu/libc-start.c:258
> Thread T9 created by T0 here:
>    #0 0x7e88813 in pthread_create _asan_rtl_
>    #1 0x26a4fc9 in base::(anonymous namespace)::CreateThread(unsigned
> long, bool, base::PlatformThread::Delegate*, unsigned long*)
> base/threading/platform_thread_posix.cc:0
>    #2 0x26a4eca in base::PlatformThread::Create(unsigned long,
> base::PlatformThread::Delegate*, unsigned long*) ???:0
>    #3 0x26a6d55 in
> base::Thread::StartWithOptions(base::Thread::Options const&) ???:0
>    #4 0x6863e5b in
> content::BrowserMainLoop::RunMainMessageLoopParts(bool*) ???:0
>    #5 0x6acbf62 in BrowserMain(content::MainFunctionParams const&) ???:0
>    #6 0x72ab86b in BrowserTestBase::SetUp() ???:0
>    #7 0x2561e42 in InProcessBrowserTest::SetUp() ???:0
>    #8 0x2d56f14 in testing::Test::Run() ???:0
>    #9 0x2d58eaa in testing::TestInfo::Run() ???:0
>    #10 0x2d5a4c8 in testing::TestCase::Run() ???:0
>    #11 0x2d672bf in testing::internal::UnitTestImpl::RunAllTests() ???:0
>    #12 0x2d6697f in bool
>
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) ???:0
>    #13 0x2d6677b in testing::UnitTest::Run() ???:0
>    #14 0x26f43c8 in base::TestSuite::Run() ???:0
>    #15 0xda6ec9 in ChromeTestLauncherDelegate::RunTestSuite(int, char**) ???:0
>    #16 0xeac27e in
> test_launcher::LaunchTests(test_launcher::TestLauncherDelegate*, int,
> char**) ???:0
>    #17 0xda6ba6 in main ???:0
>    #18 0x7fdc0c648c4d in __libc_start_main
> /build/buildd/eglibc-2.11.1/csu/libc-start.c:258
> ==3381== ABORTING
> Shadow byte and word:
>  0x1ffb7ecdc643: fd
>  0x1ffb7ecdc640: fd fd fd fd fd fd fd fd
> More shadow bytes:
>  0x1ffb7ecdc620: fd fd fd fd fd fd fd fd
>  0x1ffb7ecdc628: fd fd fd fd fd fd fd fd
>  0x1ffb7ecdc630: fd fd fd fd fd fd fd fd
>  0x1ffb7ecdc638: fd fd fd fd fd fd fd fd
> =>0x1ffb7ecdc640: fd fd fd fd fd fd fd fd
>  0x1ffb7ecdc648: fd fd fd fd fd fd fd fd
>  0x1ffb7ecdc650: fa fa fa fa fa fa fa fa
>  0x1ffb7ecdc658: fa fa fa fa fa fa fa fa
>  0x1ffb7ecdc660: fa fa fa fa fa fa fa fa
>
> 2011/12/7 Jói Sigurðsson <joi@chromium.org>:
>> That's because it's a straight revert.  Will do a good old-fashioned try.
>>
>> On Wed, Dec 7, 2011 at 12:42 PM,  <commit-bot@chromium.org> wrote:
>>> Presubmit check for 8832006-1 failed and returned exit status 1.
>>>
>>> Running presubmit commit checks ...
>>>
>>> ** Presubmit Messages **
>>> --tbr was specified, skipping OWNERS check
>>>
>>> If this change requires manual test instructions to QA team, add
>>> TEST=[instructions].
>>>
>>> ** Presubmit Warnings **
>>> Found lines longer than 80 characters (first 5 shown).
>>>  net/disk_cache/in_flight_backend_io.h, line 174, 83 chars \
>>>  net/http/http_cache.h, line 160, 81 chars \
>>>  net/http/mock_http_cache.cc, line 284, 83 chars \
>>>  net/http/mock_http_cache.cc, line 307, 82 chars
>>>
>>> The old callback system is deprecated. If possible, use base::Bind and
>>> base::Callback instead.
>>>    net/http/mock_http_cache.cc:328
>>>
>>> Presubmit checks took 2.3s to calculate.
>>>
>>>
>>>
>>> http://codereview.chromium.org/8832006/